From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D948EC6FA8F for ; Thu, 24 Aug 2023 18:31:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240123AbjHXSbA (ORCPT ); Thu, 24 Aug 2023 14:31:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243096AbjHXSax (ORCPT ); Thu, 24 Aug 2023 14:30:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9FC819A3 for ; Thu, 24 Aug 2023 11:30:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8A39464452 for ; Thu, 24 Aug 2023 18:30:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id E8608C433C7; Thu, 24 Aug 2023 18:30:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692901851; bh=DeKeaZL0R5C/9qoo3WdGT1JoCeASs543LFqTiYO4SKA=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=gXeWfMyB2VhAyi5FbRhfzVdWwr0KglhxFR1AwH11pWitYlB3vOwB4Vx08HKYAiWfq zFR4opzgn4FP/UMRE7PkX6XvG/JMkGW+mWZNBuE54XFXDRWwswx7CdF9V34ehZatxj mFFdCVsJehp3Wt5saC4Igkhq3GRP6tn94mwJaq8MBbIbMpCMxBvHQGU6n5BpT5bL8S EzdJDTJ6k2bgecaBeiDESnRmSt0owFSDfy3fMGZ8lvRMMmR+10LadxIE3dfRsZ0YRS OquaqWsCn+kZ1SVtvgGbv5Ic/fUmW4g/0HJsNrrTEjHdIl9wzu0yvYbs1ncKtq0gNV MwdtnRf2UF+Kw== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id D220FE21EDF; Thu, 24 Aug 2023 18:30:50 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next v2] net: generalize calculation of skb extensions length From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169290185085.21414.5074142110949284955.git-patchwork-notify@kernel.org> Date: Thu, 24 Aug 2023 18:30:50 +0000 References: <20230823-skb_ext-simplify-v2-1-66e26cd66860@weissschuh.net> In-Reply-To: <20230823-skb_ext-simplify-v2-1-66e26cd66860@weissschuh.net> To: =?utf-8?q?Thomas_Wei=C3=9Fschuh_=3Clinux=40weissschuh=2Enet=3E?=@ci.codeaurora.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, robimarko@gmail.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Wed, 23 Aug 2023 11:28:38 +0200 you wrote: > Remove the necessity to modify skb_ext_total_length() when new extension > types are added. > Also reduces the line count a bit. > > With optimizations enabled the function is folded down to the same > constant value as before during compilation. > This has been validated on x86 with GCC 6.5.0 and 13.2.1. > Also a similar construct has been validated on godbolt.org with GCC 5.1. > In any case the compiler has to be able to evaluate the construct at > compile-time for the BUILD_BUG_ON() in skb_extensions_init(). > > [...] Here is the summary with links: - [net-next,v2] net: generalize calculation of skb extensions length https://git.kernel.org/netdev/net-next/c/5d21d0a65b57 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html