* [PATCH net] sfc: Check firmware supports Ethernet PTP filter
@ 2023-08-24 16:46 alex.austin
2023-08-26 2:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: alex.austin @ 2023-08-24 16:46 UTC (permalink / raw)
To: netdev, linux-net-drivers, linux-kernel
Cc: davem, edumazet, kuba, pabeni, richardcochran, ihuguet,
ecree.xilinx, habetsm.xilinx, Alex Austin
From: Alex Austin <alex.austin@amd.com>
Not all firmware variants support RSS filters. Do not fail all PTP
functionality when raw ethernet PTP filters fail to insert.
Fixes: e4616f64726b ("sfc: support PTP over Ethernet")
Signed-off-by: Alex Austin <alex.austin@amd.com>
Acked-by: Edward Cree <ecree.xilinx@gmail.com>
Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
---
drivers/net/ethernet/sfc/ptp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c
index 0c40571133cb..00cf6de3bb2b 100644
--- a/drivers/net/ethernet/sfc/ptp.c
+++ b/drivers/net/ethernet/sfc/ptp.c
@@ -1485,7 +1485,9 @@ static int efx_ptp_insert_multicast_filters(struct efx_nic *efx)
goto fail;
rc = efx_ptp_insert_eth_multicast_filter(efx);
- if (rc < 0)
+
+ /* Not all firmware variants support this filter */
+ if (rc < 0 && rc != -EPROTONOSUPPORT)
goto fail;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] sfc: Check firmware supports Ethernet PTP filter
2023-08-24 16:46 [PATCH net] sfc: Check firmware supports Ethernet PTP filter alex.austin
@ 2023-08-26 2:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-08-26 2:10 UTC (permalink / raw)
To: alex.austin
Cc: netdev, linux-net-drivers, linux-kernel, davem, edumazet, kuba,
pabeni, richardcochran, ihuguet, ecree.xilinx, habetsm.xilinx
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 24 Aug 2023 17:46:57 +0100 you wrote:
> From: Alex Austin <alex.austin@amd.com>
>
> Not all firmware variants support RSS filters. Do not fail all PTP
> functionality when raw ethernet PTP filters fail to insert.
>
> Fixes: e4616f64726b ("sfc: support PTP over Ethernet")
> Signed-off-by: Alex Austin <alex.austin@amd.com>
> Acked-by: Edward Cree <ecree.xilinx@gmail.com>
> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
>
> [...]
Here is the summary with links:
- [net] sfc: Check firmware supports Ethernet PTP filter
https://git.kernel.org/netdev/net/c/c4413a20fa6d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-26 2:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-24 16:46 [PATCH net] sfc: Check firmware supports Ethernet PTP filter alex.austin
2023-08-26 2:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox