Re: [PATCH] Export current_is_keventd() for libphy

Jeff Garzik
2006-12-07T17:05:57Z

Yes, I merged the code, but looking deeper at phy its clear I missed
some things.

Looking into libphy's workqueue stuff, it has the following sequence:

disable interrupts
schedule_work()

... time passes ...
... workqueue routine is called ...

enable interrupts
handle interrupt

I really have to question if a workqueue was the best choice of
direction for such a sequence. You don't want to put off handling an
interrupt, with interrupts disabled, for a potentially unbounded amount
of time.

Maybe the best course of action is to mark it with CONFIG_BROKEN until
it gets fixed.

Jeff