From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753182AbaEUWKl (ORCPT ); Wed, 21 May 2014 18:10:41 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:37848 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753282AbaEUWKj (ORCPT ); Wed, 21 May 2014 18:10:39 -0400 From: James Hogan To: Paul Moore , Andy Lutomirski Cc: Markos Chandras , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Ralf Baechle , Eric Paris Subject: Re: [PATCH 3.15] MIPS: Add new AUDIT_ARCH token for the N32 ABI on MIPS64 Date: Wed, 21 May 2014 23:10:27 +0100 Message-ID: <1694165.itQDzbHNHb@radagast> Organization: Imagination Technologies User-Agent: KMail/4.12.5 (Linux/3.15.0-rc5+; KDE/4.12.5; x86_64; ; ) In-Reply-To: <1683789.b73kOmCp2z@sifl> References: <1397550996-14805-1-git-send-email-markos.chandras@imgtec.com> <2398159.J868kTHAKn@sifl> <1683789.b73kOmCp2z@sifl> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2871445.J1gy5gfS4s"; micalg="pgp-sha1"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart2871445.J1gy5gfS4s Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Wednesday 21 May 2014 16:59:22 Paul Moore wrote: > On Monday, May 12, 2014 02:53:05 PM Paul Moore wrote: > > On Tuesday, April 22, 2014 03:40:36 PM Markos Chandras wrote: > > > A MIPS64 kernel may support ELF files for all 3 MIPS ABIs > > > (O32, N32, N64). Furthermore, the AUDIT_ARCH_MIPS{,EL}64 token > > > does not provide enough information about the ABI for the 64-bit > > > process. As a result of which, userland needs to use complex > > > seccomp filters to decide whether a syscall belongs to the o32 or n32 > > > or n64 ABI. Therefore, a new arch token for MIPS64/n32 is added so it > > > can be used by seccomp to explicitely set syscall filters for this ABI. > > > > > > Link: http://sourceforge.net/p/libseccomp/mailman/message/32239040/ > > > Cc: Andy Lutomirski > > > Cc: Eric Paris > > > Cc: Paul Moore > > > Cc: Ralf Baechle > > > Signed-off-by: Markos Chandras > > > --- > > > Ralf, can we please have this in 3.15 (Assuming it's ACK'd)? > > > > > > Thanks a lot! > > > --- > > > > > > arch/mips/include/asm/syscall.h | 2 ++ > > > include/uapi/linux/audit.h | 12 ++++++++++++ > > > 2 files changed, 14 insertions(+) > > > > [NOTE: Adding lkml to the To line to hopefully spur discussion/acceptance > > as this *really* should be in 3.15] > > > > I'm re-replying to this patch and adding lkml to the To line because I > > believe it is very important we get this patch into 3.15. For those who > > don't follow the MIPS architecture very closely, the upcoming 3.15 is the > > first release to include support for seccomp filters, the latest > > generation > > of syscall filtering which used a BPF based filter language. For reason > > that are easy to understand, the syscall filters are ABI specific (e.g. > > syscall tables, word length, endianness) and those generating syscall > > filters in userspace (e.g. libseccomp) need to take great care to ensure > > that the generated filters take the ABI into account and fail safely in > > the > > case where a different ABI is used (e.g. x86, x86_64, x32). > > > > The patch below corrects, what is IMHO, an omission in the original MIPS > > seccomp filter patch, allowing userspace to easily separate MIPS and > > MIPS64. Without this patch we will be forced to handle MIPS/MIPS64 like > > we handle x86_64/x32 which is a royal pain and not something I want to > > have deal with again. > > > > Further, while I don't want to speak for the audit folks, it is my > > understanding that they want this patch for similar reasons. > > > > Please merge this patch for 3.15 or at least provide some feedback as to > > why this isn't a viable solution for upstream. Once 3.15 ships, fixing > > this will require breaking the MIPS ABI which isn't something any of us > > want. > > > > Thanks, > > -Paul > > *Bump* > > I don't know what else needs to be done to get some action on this and we're > running out of time for 3.15. It was merged yesterday: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c7d6891a770aa97dd36c2df3545031e64c6a0ef3 Cheers James --nextPart2871445.J1gy5gfS4s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAABAgAGBQJTfSRaAAoJEGwLaZPeOHZ6c54P/1t5J9KmkWuVSaVQzCAduSCK mLqTDXmn/D/r0nFIPZZLIYu+eZvHoFugQtntv0b6jR+HB/dqBuP66H+Ii87j1zp1 Hj6dM0yFh2+UeQK+auD4U4WnZkwxOPU3ubOLH9f7EUZ6MoUgydqNSUMoMWdJQVgH vgx0l63Vt/vIiwg2vvD3vtPZlBDhwwUfAjc0uQZ+dAN0+c0JLmPd88yNna3Rgcb3 wnV3twmwe6vYXr+yJoH4aui4AaJ6GYMfuCAD2nv45Qi1Q54C3chwEfGf9+9xkYOt XH1Kje08B4yXWzryXbivGmBlH9juzp4jOyzokYdBK3nAHRzsY1TllpQCMwHl/U8V gCrNlsLIfQeL8pxuFtmwvRyO495y1CaiykBULB2CTqbhulI1lZU6fNmtJBD7t1dF 5PFAW23nSmaGYjJ5rD0wZVP2NyNl+80mBsv/qzwkiG9rE3je3PK2awb6fEJ82CI4 L+1/p6ymMQzBodabsCMjdRNIf2VnjzrM645ZeD2jjDv4FeWQH/Tc9AYjyEf9SqIY PXZsoCfupebaf6dITzCwHJSSVtXLdG9pHwK4ofm36Uta9tOh019jAWfo+bseou31 DBMF8TQssmn82qYTOlY/JegfAmlt3UcQBUIpl2vyxhoAqk9JyckNtRpX2YW5J5E7 CZ3E9/HYg79Xbwzp6G1e =DcX3 -----END PGP SIGNATURE----- --nextPart2871445.J1gy5gfS4s--