Re: [FIX PATCH] selftests: tracing: Fix to unmount tracefs for recovering environment

Steven Rostedt
2023-09-12T03:02:50Z

On Tue, 12 Sep 2023 09:54:57 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:

> > Shouldn't the above be:
> >
> > if [ ! -z "${UNMOUNT_DIR}" ]; then
> >
> > ?
>
> I think both are good.
> What about using '-n' explictly?
>
> [ -n "${UNMOUNT_DIR}" ]

Even better. Heh, I never even knew about that switch :-p

-- Steve