Re: [PATCH 00/42] SH pin control and GPIO rework

Linus Walleij
2012-11-21T14:52:00Z

On Wed, Nov 21, 2012 at 3:27 AM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:

> The idea behind these patches is to move SoC-specific pin control code from
> arch/ to drivers/pinctrl/ and use the Linux device model to instantiate the
> pin control device. This is required to add device tree support for the pin
> control device.

Ah, this looks nice :-)

> The SH7264 and SH7269 platforms have no gpiolib support so the PFC code can't
> be compiled for them. As the currently implemented arch-level pinmux support
> also depends on generic GPIO, we're moving from a situation where the code
> isn't used to a different situation where the code isn't used. I don't
> consider that as a regression.

That's OK, would be nice to get rid of this one day though.

I will try to go through and review patches individually. I'll
focus on pinctrl/GPIO mechanisms and trust you and Paul M
to know that the SH side of things are correct.

Yours,
Linus Walleij