From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753760AbbJAIds (ORCPT ); Thu, 1 Oct 2015 04:33:48 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:51820 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752163AbbJAIdj (ORCPT ); Thu, 1 Oct 2015 04:33:39 -0400 From: Arnd Bergmann To: Lijun Pan Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] fsl-ifc: fix compilation error on ARM's 42 bit VA Date: Thu, 01 Oct 2015 10:33:31 +0200 Message-ID: <1694323.vYGVsqBdJK@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1443653742-23177-1-git-send-email-Lijun.Pan@freescale.com> References: <1443653742-23177-1-git-send-email-Lijun.Pan@freescale.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:HDSwia/3CjegrXQMwOZF80plTFmMT5w4YC4nKrz41oLDssEdLuz pq4AQwLDuv0kKnmumsSWEjHzBADpQstHBymvH0PIDfwbTbgzQfJs058+EjofvTDYA4q4ypv H5d7H1V+C9kdd7oR/uhl2ByUPC4uPZ09VRAdf1jNBsnW99hQzJVnpNBlny3RvHdaZdyG/Kw v11x4rHtXVIX8iZcZ16Xw== X-UI-Out-Filterresults: notjunk:1;V01:K0:9qsfE3yCb/M=:qTUC6qcderEZZKTNU5sUXA Lj40i+EOjPOBFR2TU4xcqU8gTnMI5WGhp7CBJ2izHg8TCvRUaJYO6F8t7qaQ2wf58FGwbX0hf cr1r1DR0AzSM86+WP8Pt43CJYzn0khNGUeKKfvtvYlUM+zIKShm7E8yx1b4Dmn0oNq0Sljbl2 u+gHw2y1CY+W4kMEcAo916Opvlts8Mu7SwbjKjBDmarz/vmURB9qNPooDOXyzgOen3vpuV8uM oXtCjiM/GzE3QBApfX3MTGVdPbT494lCFOv+fQtICc9IdSmX6k5JzzWsYpFWad1cjp/lsNj4r c5rPeUWei97cfMgdZfq7iJEYIOP942TQrRzBZguVSKMuv7Psx0njA3W04VCfkaTZv2wRpoS8L QclHrTbHbMCKT1hgVQKpFUFCs2e1wRUjEMOei9CWKzero0WdRYRUefCNZZqx5yP8XDKxq1hPx Z83mvLZzkNeabxxeESx1YZrwa2uw2O0RaHV9NibryvvHA4KKEj82MbNMdYv/4GdY0sH3DFigS V+vtXipnQ42lc8rBDudCKER8CORoqCtmOvIeukE09eATby/OicUt8DLAAZIA43FGt6k/mJ3zW zHj5O93Z6aROgUqpePnmYVPh7ONCBRZBUEb/5at90nbdhDSFumNjdpbJ0/inlH5yP67JkIVP7 +kf92gX3qEyQtZsGCLGAeDeEEylhsOd7BfRw9V41+sLQVwu/p57AkiMU3vB85a4BntFUaiDpS Js9bbffM67Bu8j7f Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 30 September 2015 17:55:42 Lijun Pan wrote: > Need to include sched.h to fix the following compilation error > if FSL_IFC is enabled on ARM64 machine. That's good, but you did not change the subject line accordingly. > Also, sort the include files by alphabetical order. No need to reorder the other lines, just try to fit it in as good as possible. > Since ./arch/arm64/include/asm/stat.h does not > include ./arch/arm64/include/asm/compat.h, > it will not include include/linux/sched.h > Hence we have to manually add "#include " > in drivers/memory/fsl_ifc.c Ok, good job explaining what happened. Arnd