* [PATCH net-next] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next()
@ 2023-09-12 8:42 Gavrilov Ilia
2023-09-12 15:42 ` David Ahern
2023-09-14 15:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Gavrilov Ilia @ 2023-09-12 8:42 UTC (permalink / raw)
To: David S. Miller
Cc: David Ahern, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
The 'state->im' value will always be non-zero after
the 'while' statement, so the check can be removed.
Found by InfoTeCS on behalf of Linux Verification Center
(linuxtesting.org) with SVACE.
Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
---
Repost according to https://lore.kernel.org/all/fea6db56-3a01-b7c8-b800-a6c885e99feb@kernel.org/
net/ipv4/igmp.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index 418e5fb58fd3..76c3ea75b8dd 100644
--- a/net/ipv4/igmp.c
+++ b/net/ipv4/igmp.c
@@ -2944,8 +2944,6 @@ static struct ip_sf_list *igmp_mcf_get_next(struct seq_file *seq, struct ip_sf_l
continue;
state->im = rcu_dereference(state->idev->mc_list);
}
- if (!state->im)
- break;
spin_lock_bh(&state->im->lock);
psf = state->im->sources;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next()
2023-09-12 8:42 [PATCH net-next] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next() Gavrilov Ilia
@ 2023-09-12 15:42 ` David Ahern
2023-09-14 15:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: David Ahern @ 2023-09-12 15:42 UTC (permalink / raw)
To: Gavrilov Ilia, David S. Miller
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
On 9/12/23 2:42 AM, Gavrilov Ilia wrote:
> The 'state->im' value will always be non-zero after
> the 'while' statement, so the check can be removed.
>
> Found by InfoTeCS on behalf of Linux Verification Center
> (linuxtesting.org) with SVACE.
>
> Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
> ---
> Repost according to https://lore.kernel.org/all/fea6db56-3a01-b7c8-b800-a6c885e99feb@kernel.org/
> net/ipv4/igmp.c | 2 --
> 1 file changed, 2 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next()
2023-09-12 8:42 [PATCH net-next] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next() Gavrilov Ilia
2023-09-12 15:42 ` David Ahern
@ 2023-09-14 15:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-09-14 15:40 UTC (permalink / raw)
To: Gavrilov Ilia
Cc: davem, dsahern, edumazet, kuba, pabeni, netdev, linux-kernel,
lvc-project
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Tue, 12 Sep 2023 08:42:34 +0000 you wrote:
> The 'state->im' value will always be non-zero after
> the 'while' statement, so the check can be removed.
>
> Found by InfoTeCS on behalf of Linux Verification Center
> (linuxtesting.org) with SVACE.
>
> Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
>
> [...]
Here is the summary with links:
- [net-next] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next()
https://git.kernel.org/netdev/net-next/c/a613ed1afd96
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-14 15:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-12 8:42 [PATCH net-next] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next() Gavrilov Ilia
2023-09-12 15:42 ` David Ahern
2023-09-14 15:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox