From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jim Lin <jilin@nvidia.com>
Cc: mchehab@kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1 V2] media: usb: uvc: Fix incorrect timeout for Get Request
Date: Fri, 14 Jul 2017 10:34:23 +0300 [thread overview]
Message-ID: <1696193.EoNaQecsU9@avalon> (raw)
In-Reply-To: <3a7d73bb-45f8-4803-ee9b-8bf2ead84017@nvidia.com>
Hi Jim,
On Friday 14 Jul 2017 09:58:11 Jim Lin wrote:
> On 2017年07月11日 03:47, Laurent Pinchart wrote:
> > On Monday 10 Jul 2017 14:43:49 Jim Lin wrote:
> >> Section 9.2.6.4 of USB 2.0/3.x specification describes that
> >> "device must be able to return the first data packet to host within
> >> 500 ms of receipt of the request. For subsequent data packet, if any,
> >> the device must be able to return them within 500 ms".
> >>
> >> This is to fix incorrect timeout and change it from 300 ms to 500 ms
> >> to meet the timing specified by specification for Get Request.
> >>
> >> Signed-off-by: Jim Lin <jilin@nvidia.com>
> >
> > The patch looks good to me, so
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > but I'm curious, have you noticed issues with some devices in practice ?
>
> Sometimes this device takes about 360 ms to respond.
>
> usb 1-2: new high-speed USB device number 16
> usb 1-2: New USB device found, idVendor=045e, idProduct=0772
> usb 1-2: New USB device strings: Mfr=1, Product=2, SerialNumber=0
> usb 1-2: Product: Microsoft�® LifeCam Studio(TM)
> usb 1-2: Manufacturer: Microsoft
>
> uvcvideo: Failed to query (GET_DEF) UVC control 2 on unit 4: -110 (exp. 2).
>
> And it will be working well with correct timeout value.
Thank you for the information.
I've applied the patch to my tree and will push it to v4.14.
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2017-07-14 7:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 6:43 [PATCH 1/1 V2] media: usb: uvc: Fix incorrect timeout for Get Request Jim Lin
2017-07-10 19:47 ` Laurent Pinchart
2017-07-14 2:11 ` Jim Lin
[not found] ` <3a7d73bb-45f8-4803-ee9b-8bf2ead84017@nvidia.com>
2017-07-14 7:34 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1696193.EoNaQecsU9@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=jilin@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox