From: patchwork-bot+netdevbpf@kernel.org
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: peter@korsgaard.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
syzbot+1f53a30781af65d2c955@syzkaller.appspotmail.com,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read
Date: Wed, 11 Oct 2023 03:10:25 +0000 [thread overview]
Message-ID: <169699382568.3301.6960021020124970856.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20231009-topic-dm9601_uninit_mdio_read-v2-1-f2fe39739b6c@gmail.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 10 Oct 2023 00:26:14 +0200 you wrote:
> syzbot has found an uninit-value bug triggered by the dm9601 driver [1].
>
> This error happens because the variable res is not updated if the call
> to dm_read_shared_word returns an error. In this particular case -EPROTO
> was returned and res stayed uninitialized.
>
> This can be avoided by checking the return value of dm_read_shared_word
> and propagating the error if the read operation failed.
>
> [...]
Here is the summary with links:
- [v2] net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read
https://git.kernel.org/netdev/net/c/8f8abb863fa5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-10-11 3:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 22:26 [PATCH v2] net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read Javier Carrasco
2023-10-10 6:00 ` Greg KH
2023-10-10 6:19 ` Peter Korsgaard
2023-10-10 6:33 ` Greg KH
2023-10-10 7:22 ` Peter Korsgaard
2023-10-10 7:28 ` Greg KH
2023-10-11 3:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169699382568.3301.6960021020124970856.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peter@korsgaard.com \
--cc=syzbot+1f53a30781af65d2c955@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox