Re: [PATCH 05/13] libnvdimm, blk: use devm_add_action to release bdev resources

Dan Williams
2016-03-24T15:14:55Z

On Thu, Mar 24, 2016 at 4:48 AM, Johannes Thumshirn <jthumshirn@suse.de> wrote:
> On Mittwoch, 23. März 2016 18:25:47 CET Dan Williams wrote:
>> Register a callback to clean up the request_queue and put the gendisk at
>> driver disable time.
>>
>> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
>> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
>
> [...]
>
>>
>> static int nd_blk_remove(struct device *dev)
>> {
>> - struct nd_blk_device *blk_dev = dev_get_drvdata(dev);
>> -
>> if (is_nd_btt(dev))
>> nvdimm_namespace_detach_btt(to_nd_btt(dev));
>> - else
>> - nd_blk_detach_disk(blk_dev);
>> - kfree(blk_dev);
>> -
>> return 0;
>> }
>>
>
> Can't this be void?
>

That's not how the core defines this:

struct device_driver {
...
int (*remove) (struct device *dev);
...
};