Re: [PATCH 08/13] libnvdimm, blk: move i/o infrastructure to nd_namespace_blk

Dan Williams
2016-03-24T15:21:35Z

On Thu, Mar 24, 2016 at 5:22 AM, Johannes Thumshirn <jthumshirn@suse.de> wrote:
> On Mittwoch, 23. März 2016 18:26:03 CET Dan Williams wrote:
>> Consolidate the information for issuing i/o to a blk-namespace, and
>> eliminate some pointer chasing.
>>
>> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
>> ---
> [...]
>> BUG_ON(len > PAGE_SIZE);
>> - err = nd_blk_do_bvec(blk_dev, bip, bvec.bv_page, len,
>> - bvec.bv_offset, rw, iter.bi_sector);
>> + err = nsblk_do_bvec(nsblk, bip, bvec.bv_page, len,
>> + bvec.bv_offset, rw, iter.bi_sector);
>> if (err) {
>> - dev_info(&blk_dev->nsblk->common.dev,
>> + dev_dbg(&nsblk->common.dev,
>> "io error in %s sector %lld, len %d,\n",
>> (rw == READ) ? "READ" : "WRITE",
>> (unsigned long long) iter.bi_sector, len);
>
> Why is an I/O error suddently a debug message instead of an error?

True, that's a jarring change not described in the log, should
probably be its own patch. The rationale is that upper layers already
have error prints for failed commands and this one is redundant.