Re: [PATCH 11/13] libnvdimm, pmem, pfn: make pmem_rw_bytes generic and refactor pfn setup

Johannes Thumshirn
2016-03-24T13:50:55Z

On Mittwoch, 23. März 2016 18:26:18 CET Dan Williams wrote:
> In preparation for providing an alternative (to block device) access
> mechanism to persistent memory, convert pmem_rw_bytes() to
> nsio_rw_bytes(). This allows ->rw_bytes() functionality without
> requiring a 'struct pmem_device' to be instantiated.
>
> In other words, when ->rw_bytes() is in use i/o is driven through
> 'struct nd_namespace_io', otherwise it is driven through 'struct
> pmem_device' and the block layer. This consolidates the disjoint calls
> to devm_exit_badblocks() and devm_memunmap() into a common
> devm_nsio_disable() and cleans up the init path to use a unified
> pmem_attach_disk() implementation.
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>

--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850