* [PATCH] VMCI: fix to pass correct device identity to free_irq()
@ 2013-09-06 6:39 Wei Yongjun
2013-09-06 6:55 ` Dmitry Torokhov
2013-09-06 14:22 ` Andy King
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2013-09-06 6:39 UTC (permalink / raw)
To: acking, gregkh, dtor, georgezhang, asarwade; +Cc: yongjun_wei, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
free_irq() expects the same device identity that was passed to
corresponding request_irq(), otherwise the IRQ is not freed.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/misc/vmw_vmci/vmci_guest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc/vmw_vmci/vmci_guest.c
index b3a2b76..c98b03b 100644
--- a/drivers/misc/vmw_vmci/vmci_guest.c
+++ b/drivers/misc/vmw_vmci/vmci_guest.c
@@ -649,7 +649,7 @@ static int vmci_guest_probe_device(struct pci_dev *pdev,
return 0;
err_free_irq:
- free_irq(vmci_dev->irq, &vmci_dev);
+ free_irq(vmci_dev->irq, vmci_dev);
tasklet_kill(&vmci_dev->datagram_tasklet);
tasklet_kill(&vmci_dev->bm_tasklet);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] VMCI: fix to pass correct device identity to free_irq()
2013-09-06 6:39 [PATCH] VMCI: fix to pass correct device identity to free_irq() Wei Yongjun
@ 2013-09-06 6:55 ` Dmitry Torokhov
2013-09-06 14:22 ` Andy King
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2013-09-06 6:55 UTC (permalink / raw)
To: Wei Yongjun
Cc: acking, gregkh, georgezhang, asarwade, yongjun_wei, linux-kernel
On Fri, Sep 06, 2013 at 02:39:28PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> free_irq() expects the same device identity that was passed to
> corresponding request_irq(), otherwise the IRQ is not freed.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Dmitry Torokhov <dtor@vmware.com>
> ---
> drivers/misc/vmw_vmci/vmci_guest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc/vmw_vmci/vmci_guest.c
> index b3a2b76..c98b03b 100644
> --- a/drivers/misc/vmw_vmci/vmci_guest.c
> +++ b/drivers/misc/vmw_vmci/vmci_guest.c
> @@ -649,7 +649,7 @@ static int vmci_guest_probe_device(struct pci_dev *pdev,
> return 0;
>
> err_free_irq:
> - free_irq(vmci_dev->irq, &vmci_dev);
> + free_irq(vmci_dev->irq, vmci_dev);
> tasklet_kill(&vmci_dev->datagram_tasklet);
> tasklet_kill(&vmci_dev->bm_tasklet);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] VMCI: fix to pass correct device identity to free_irq()
2013-09-06 6:39 [PATCH] VMCI: fix to pass correct device identity to free_irq() Wei Yongjun
2013-09-06 6:55 ` Dmitry Torokhov
@ 2013-09-06 14:22 ` Andy King
1 sibling, 0 replies; 3+ messages in thread
From: Andy King @ 2013-09-06 14:22 UTC (permalink / raw)
To: Wei Yongjun
Cc: gregkh, dtor, georgezhang, asarwade, yongjun wei, linux-kernel
> free_irq() expects the same device identity that was passed to
> corresponding request_irq(), otherwise the IRQ is not freed.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Andy King <acking@vmware.com>
Thanks for fixing this!
- Andy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-06 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-06 6:39 [PATCH] VMCI: fix to pass correct device identity to free_irq() Wei Yongjun
2013-09-06 6:55 ` Dmitry Torokhov
2013-09-06 14:22 ` Andy King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox