Re: [PATCH net-next 01/12] dt-bindings: ptp: add bindings for NETC Timer

[Krzysztof Kozlowski <krzk@kernel.org>]

On 14/07/2025 11:11, Wei Fang wrote:
>>>>> +  nxp,pps-channel:
>>>>> +    $ref: /schemas/types.yaml#/definitions/uint8
>>>>> +    default: 0
>>>>> +    description:
>>>>> +      Specifies to which fixed interval period pulse generator is
>>>>> +      used to generate PPS signal.
>>>>> +    enum: [0, 1, 2]
>>>>
>>>> Cell phandle tells that. Drop property.
>>>
>>> Sorry, I do not understand what you mean, could you explain it in more
>>> detail?
>>
>> Use phandle cells for that - look at other PTP bindings.
> 
> Sorry, I did not find a reference in other PTP bindings. If I understand
> correctly, you mean I should add a specific cells property to this doc
> as follows, correct?
> 
> "#nxp,pps-channel-cells":
>     description: |
>       Specifies to which fixed interval period pulse generator is
>       used to generate PPS signal.
>     $ref: /schemas/types.yaml#/definitions/uint32
>     const: 1
> 


No. Is this a timestamper device? You really did not find a TXT document
describing this, in the same directory? Well, maybe it is not a
timestamper device, how do I know, your description should be clear here.

How does the other consumer - ethernet - reference this one here? Paste
complete DTS of this and users, otherwise it is just ping-pong
discussion where you put just a little effort to bounce back my question.


Best regards,
Krzysztof