From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933267AbeALBEB (ORCPT + 1 other); Thu, 11 Jan 2018 20:04:01 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:34301 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932860AbeALBD6 (ORCPT ); Thu, 11 Jan 2018 20:03:58 -0500 X-Google-Smtp-Source: ACJfBovlhkY2GzzuqKtK2QZWsWLOLc/RSkQPHrQsYykifSfJGFEReeS7x/612GBmYDSMtjKgMFRLtA== Subject: Re: [PATCH] soc: brcmstb: Only register SoC device on STB platforms To: Olof Johansson , Thierry Reding Cc: Brian Norris , Gregory Fong , arm@kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20180109145409.11612-1-thierry.reding@gmail.com> <20180112010130.3tz7hnmzs74trwhw@localhost> From: Florian Fainelli Message-ID: <16b38f56-8431-71d3-2fc6-ea102bd803e1@gmail.com> Date: Thu, 11 Jan 2018 17:03:53 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180112010130.3tz7hnmzs74trwhw@localhost> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/11/2018 05:01 PM, Olof Johansson wrote: > On Tue, Jan 09, 2018 at 03:54:09PM +0100, Thierry Reding wrote: >> From: Thierry Reding >> >> After moving the SoC device initialization to an early initcall in >> commit f780429adfbc ("soc: brcmstb: biuctrl: Move to early_initcall"), >> the Broadcom STB SoC device is registered on all platforms if support >> for the device is enabled in the kernel configuration. >> >> This causes an additional SoC device to appear on platforms that already >> register a native one. In case of Tegra the STB SoC device is registered >> as soc0 (with totally meaningless content in the sysfs attributes) and >> causes various scripts and programs to fail because they don't know how >> to parse that data. >> >> To fix this, duplicate the check from brcmstb_soc_device_early_init() >> that already prevents the code from doing anything nonsensical on non- >> STB platforms. >> >> Fixes: f780429adfbc ("soc: brcmstb: biuctrl: Move to early_initcall") >> Signed-off-by: Thierry Reding >> --- > > > Thanks, applied. Thanks for picking that up, I was just going to submit it. -- Florian