From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034572AbcIZM3z (ORCPT ); Mon, 26 Sep 2016 08:29:55 -0400 Received: from mout.web.de ([212.227.15.4]:52533 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934871AbcIZM3x (ORCPT ); Mon, 26 Sep 2016 08:29:53 -0400 Subject: Re: ISDN-CAPI: Adjust 17 function calls together with variable assignments To: Paul Bolle References: <10355972-1c9b-1103-edf3-efde78237cdd@users.sourceforge.net> <1474881174.1846.8.camel@tiscali.nl> Cc: netdev@vger.kernel.org, Karsten Keil , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <16c50966-66f2-8a08-0ebc-936b04311f14@users.sourceforge.net> Date: Mon, 26 Sep 2016 14:28:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1474881174.1846.8.camel@tiscali.nl> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:wNX3yLoUPDXo+sV7w1eEyLsSwRRn8xTel1PXS16B43gsjooy91S DP0fYxIfzAZtfZXW7p+HyBgrbvK1PyzEJNllMDZUK4yee1D/14na0F1TkopO+t4rnppp231 x77D3FctoEpbv4N2HkYMplT2dYz4UoYkleU1YZl6heG4wQyEl3+37tXdbij7S7Rx/Fr+Sa6 mSd+BPW0b+3mdeuoB/wCQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Kh/vB5lOWak=:b82pAFP9ddemufkPygZsZS ZMPsEF7cDZc7st90OCwKceXIxxDTA807gmRPSPyli5SGtUowV5bhtyHi5IWuF94/aZK3qWpZd plRPdM4i6iT7Kvz8SKT1Z9i22aiIhajlAe9hgC5LALhiYd6RIl6hPjCg/HDcng/ddifiC3obH icxrIgbjYPRU+OzYbLBtCboQwdh5fUz5RqJ8oOJGbhQaafsCMz42hQZq4TCnhIeuBnkj8aC9i 47UoO+ueQQlPbDNJ9fnBIN0NUZlpeVgKJftronfN5ow8Y41IYsGHihHBWwGX0PnGputpJlCs5 8WDmkpibKqO82L5wc1NxwcVmKicE9/unqkBoiaDgo96uJdOI/444qN3FU4fJNgjX1wnv+1sk8 1tpV+rhFw6RxOcUkZqas0XNhVunPfRLvsLc/M+4Ps8B3I/gI+sUDsq/i7mG3yNNpTe7waoCLs Y+Xk5qR/vmg3iaeRKKnUIBRIC/3uIMe/Orxw2r3PQhCbB69J6LJv1axk8PfjGb2iNT1BbymL6 d8J9GbgAyvOLK4ZwtTg9GiLIz1rQOaYvBPZSYH3ChZAeaRiRV7zxeX2qbm2TQAU6a/+w+S9oN bJTsvu9Xf8EWFHzFT3uyy7wB2qn+NoYTYJPvC5b3rbwZY34JF6bE1R2gc8NHCMpRpzCXSxroj sKxAg8Y+qXbV81sKulzbYJPJ8U2AR7olib0uP89g2ZN7voVQMpttK+1o4DjClA485LjAwJEFW Mmr0CEh4gywu6vQmGbM/raDhlqJbmjpSd1D+QvXnld1pQ35OSQMSwpSjBgX1zP2v+fi2Nkdme ISKYrDg Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> The script "checkpatch.pl" can point out that assignments should usually >> not be performed within condition checks. >> Thus move the assignment for a variable to a separate statement >> in four functions. > > Did you recycle this commit explanation? Yes. - I am going to use similar commit messages for further changes in other software modules. > Because git diff tells me you actually touched about eight functions. You are right. - I'm sorry that I overlooked to update this number somehow. > scripts/checkpatch.pl -f drivers/isdn/capi/capidrv.c | grep "assignment in if condition" | wc -l > > It tells me there are actually 18 instances of this "ERROR". > Why did you ignore one of it in this patch? Did I accidentally leave another update candidate over? * How do you think about to pick such a software update opportunity up? * Do you expect a resend for the steps 3 - 5 of this small patch series? Regards, Markus