From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6583638B131 for ; Tue, 19 May 2026 06:24:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779171883; cv=none; b=L8+tXb2MRrPnhLwgNC7bbhOhcR+OmnDmAV7nz/nL3rkN126Rx1tmhU/iZpId8cUXZku29c/6gHlri3ZFYyZKdS15rUfZijTPC2bjzOtfJKMkXRV1XpnKAfz6VHg3Vsc9jbQauDleS/ZGzCWI/FgmARMCQfiNTu7NgVFk1ZYdK94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779171883; c=relaxed/simple; bh=ETi7lwNArEN5RcmsW98Yn9KiVogT7wbUsiY5AWvxxY0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CXFYLfpPL8TeWVj9s7oF5LpPpc1aCB05RLqdSqnBXSlJen8L3lSgGtQq1VlbYdqze734GIord6Hm3gNYUqjlxqbhFjagsCXUMskj7AWOMFUHZZ1jHbJFDzpAkA7jgWNWoljl9TKOEayJf77TlGDCzRozHfgQNa/OBGUnBxF/lm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fd6D9Xxo; arc=none smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fd6D9Xxo" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-392445f11c5so35810811fa.1 for ; Mon, 18 May 2026 23:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779171879; x=1779776679; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xfehn+9PkhGKFVZuq9YJWpl/FHglNOxtCRjIV6IYwkY=; b=fd6D9XxoencoRpTa13HKfDogDPwSX/ivrNv/ZDdFDQeVGRcvoVUoNfUjw322R4zzSC m9hGE45xxaF/CGRhJGS+IxKbESma80/5MbM4NW7Nm4Krbc9vBrrMryvYj5LFQ/fIEOI8 8kE+LhmQtw5wBQu1qAA/LJijNKlTJc+7KnslQigKPAhkCfk+YKfPz80aieKrljHiaFoO Cwovu5bD8AUj4qDV+l/E2JomKnl43Fj5WFg/ULZ1PP236Q8vCDlvESQGRmttQptATszr KVTlKNUNMceZd1eHzcFKYi6U3Vy7p5tUUspnC9b8Rd0rDtHmsOcTxe2wILgUXEncszKg 3QVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779171879; x=1779776679; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xfehn+9PkhGKFVZuq9YJWpl/FHglNOxtCRjIV6IYwkY=; b=gg0Ht+CFNSf2YGUuD3jkiQu4FsIxfAB1RV6IwO201AspVKsaUs6Q8uVxebQoey+y+S fXlT9XQYe9GGH5Oz9+4ZbXItpc6mV/RRFFdpkGl52TYiO1Rnmldy16G0lu6ouC/ot/nl t/o3r4ZbDySXH4+M3xU2+Udv5sZ45ghVyMF4uU2I7KwnYCOwVQU+1aYnxnQqbAWvzeSN hQ/qKy5wTKcK4rH9uWa7eUIbEk3tUmw2B8nBM9+wFRTWm/RT4E5nmWuDAJ84g/aNKT5E EU/jR9K1vRrO2/vFJp7KpsqmR2zVs92T8yFGxY9N++LLgfRmcwsFwaoYjhEjRihE0E/3 WlGg== X-Forwarded-Encrypted: i=1; AFNElJ+1ihO4bcswBTGpRekYLAcRbnXbk1021aiUfGVIlK/j/s50fXCWKO8YrXWH1mhppfGZPEpLzKHLbgR3HYc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3khjC8vhc99ByO1M32Z/JtVqObDxK73GpVAM1NqtDcBZADaL0 DRVMe+OlaPzc8QhA1G3v670U40w62w1PHe+V4SCWtsVlh89pQNYFQfP1tQN9Rn//F0I= X-Gm-Gg: Acq92OEAfgsRbrAPRTehgpx9YKAlfBC3UlxqVqWASUAIkNh0YQUkLfyJBuq4/aGdsQg rXy/zGmWB9E4LwA7Plo0ZEm9j8U4iuXkvhQkgBj9iWpbvTOPcbT98pxUxJW0yHJcTtqGvXQ4Apy JYdNM+B0b9Dkko6Zzp6bPCA54vhLHemXIntaL7A290LNYnyyId4s/wbVE5EiKr2kkKc6mJuA1SS 4ClU3uEOxGYzlcvCkRasYDMKu8wklzhHIpEUT/2SqfsIVzdiORFXOxtb7U+xsPUc4os/8iti08z rxpANLwl+93T6ONe3g5yKkXUE79iHMTcoy/3xLwsdF2j/4T9eeYPKHq/ZhAkaGExEp2bVUdqxoy 06mYxewuz29xA4mknCvIs8LqLb/m0BNuskQWxMStxTWBqlDyoZNOJCVBX+tZ4kygSsEjz0x2C5L +6nBwhIPZSOgzVjfJzdkinFWqX35BBRE4MXUTosX1vrX5cV5IdIAN5Ul0X7EPBXZk151qqziVWS afFCBzkDTbVKacKz8Y= X-Received: by 2002:a2e:8e70:0:b0:38e:9b7e:edd7 with SMTP id 38308e7fff4ca-3945b6098f7mr35935391fa.17.1779171879360; Mon, 18 May 2026 23:24:39 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-395887df055sm17666761fa.39.2026.05.18.23.24.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 23:24:38 -0700 (PDT) Message-ID: <16cf96a8-f559-4f2d-a50c-1c6a14ddf63c@gmail.com> Date: Tue, 19 May 2026 09:24:37 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] iio: light: veml6030: fix channel type when pushing events To: Jonathan Cameron , David Lechner Cc: Javier Carrasco , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rishi Gupta , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260513-veml6031x00-v2-0-4703ca661a1d@gmail.com> <20260513-veml6031x00-v2-2-4703ca661a1d@gmail.com> <9bb6db05-43c7-4bdf-88b0-b92525ad5cc9@gmail.com> <2a0c777d-05ef-4721-b8ed-88297630ea94@baylibre.com> <20260518162255.107faee8@jic23-huawei> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <20260518162255.107faee8@jic23-huawei> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 18/05/2026 18:22, Jonathan Cameron wrote: > On Mon, 18 May 2026 09:48:39 -0500 > David Lechner wrote: > >> On 5/18/26 8:12 AM, Matti Vaittinen wrote: >>> On 13/05/2026 07:49, Javier Carrasco wrote: >>>> The events are registered for IIO_LIGHT and not for IIO_INTENSITY. >>>> Use the correct channel type. >>>> This bug was introduced in the first version of the driver. >>>> >>>> When at it, fix minor checkpatch code style warning (alignment). >>>> >>>> Signed-off-by: Javier Carrasco >>>> --- >>>>   drivers/iio/light/veml6030.c | 8 +++++--- >>>>   1 file changed, 5 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c >>>> index 745cf3ad7092..855f052b60c2 100644 >>>> --- a/drivers/iio/light/veml6030.c >>>> +++ b/drivers/iio/light/veml6030.c >>>> @@ -871,9 +871,11 @@ static irqreturn_t veml6030_event_handler(int irq, void *private) >>>>       else >>>>           evtdir = IIO_EV_DIR_FALLING; >>>>   -    iio_push_event(indio_dev, IIO_UNMOD_EVENT_CODE(IIO_INTENSITY, >>>> -                    0, IIO_EV_TYPE_THRESH, evtdir), >>>> -                    iio_get_time_ns(indio_dev)); >>>> +    iio_push_event(indio_dev, IIO_UNMOD_EVENT_CODE(IIO_LIGHT, >>>> +                               0, >>>> +                               IIO_EV_TYPE_THRESH, >>>> +                               evtdir), >>>> +            iio_get_time_ns(indio_dev)); >>>>         return IRQ_HANDLED; >>>>   } >>>> >>> >>> Is this change reflected to the user-space? If so, is it safe? We shouldn't break the ABI, right? >> >> On things like this, we will sometime risk breaking userspace in hopes >> that no one was actually depending on it. If no one notices that we >> broke it, did we really break it? > > If it's a bug we often just break ABI compatibility anyway. If we get a report > we'll make it spit out both events (and someone doesn't handle an extra one > we point them at the docs - that hopefully exist ;) - that say you must handle > ones you don't expect). Well, you guys are the ones being grilled if the brown thing hits the fan. ;) So, if you're willing to take the risk, then I am not complaining :) Yours, -- Matti -- --- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~