From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FAE9CE79AC for ; Tue, 19 Sep 2023 18:11:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232113AbjISSLm (ORCPT ); Tue, 19 Sep 2023 14:11:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229853AbjISSLk (ORCPT ); Tue, 19 Sep 2023 14:11:40 -0400 X-Greylist: delayed 541 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 19 Sep 2023 11:11:31 PDT Received: from out-229.mta1.migadu.com (out-229.mta1.migadu.com [IPv6:2001:41d0:203:375::e5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A5648F for ; Tue, 19 Sep 2023 11:11:31 -0700 (PDT) MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1695146547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3T1NkrCByZEH+2CfK+i0EV7zh/RMykXStM3Aau3LS0o=; b=wRrjXa++TbNiIlTBlXUy4C/x8Sthlh+Df481Qf3/RjQ4CZqV8IQj+JmVe3CX8secxy4l+5 42E5NJkc/y7yVLNbZzEh4NbEWcAA5URCI5nBvkyYwV1WKKvjTU5SpuorCo7cEw6jIgk4pd E+wfNCYE/E6/AY/w3XgGuzozOzOybQY= Date: Tue, 19 Sep 2023 18:02:26 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Konstantin Ryabitsev" Message-ID: <16e1b7632d840c1cc9efa09f0710683039514d83@linux.dev> TLS-Required: No Subject: Re: [PATCH] hwmon: powerz: add support for ChargerLAB KM002C To: "=?utf-8?B?VGhvbWFzIFdlacOfc2NodWg=?=" , "Guenter Roeck" Cc: "Jean Delvare" , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, "Douglas Gilbert" In-Reply-To: <5fb278c7-df91-4f02-ab5f-baa47d27507f@t-8ch.de> References: <5fb278c7-df91-4f02-ab5f-baa47d27507f@t-8ch.de> <20230911-powerz-km002c-v1-1-898bd79b9bae@weissschuh.net> <6e5eff10-949c-4f17-a3f3-347b85b89e11@roeck-us.net> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org September 19, 2023 at 1:15 PM, "Thomas Wei=C3=9Fschuh" wrote: > On 2023-09-18 12:05:19-0700, Guenter Roeck wrote: >=20 >=20>=20 >=20> On Mon, Sep 11, 2023 at 07:44:42AM +0200, Thomas Wei=C3=9Fschuh wro= te: > > The KM002C is similar to the KM003C and seems to use the same > > protocol and firmware. > >=20=20 >=20> Reported-by: Douglas Gilbert > > Closes: https://lore.kernel.org/lkml/290ebce4-54f0-8ac1-2a13-cbc806d= 80d64@interlog.com/ > > Signed-off-by: Thomas Wei=C3=9Fschuh > > --- > >=20=20 >=20> This patch is based on hwmon-next, > > commit 80369d9e1f2f ("hwmon: (sch5627) Document behaviour of limit r= egisters"). > >=20=20 >=20> Signed-off-by: Thomas Wei=C3=9Fschuh > >=20=20 >=20> Applied, but please be more careful with your comments and Signed-= off-by: > > tags. There should only be one '---', and one signature. > >=20 >=20 > Thanks, >=20 >=20the duplicate Signed-off-by is indeed an oversight which I'll > try to avoid in the future. >=20 >=20As for the '---': >=20 >=20Two of them are generated by the 'b4' tool and I added one manually w= ith > the hwmon-next information. > For other subsystems this wasn't an issue so far. >=20 >=20Are these duplicate sections a problem for your personal tooling or i= s > it affecting something more widespread? There should be no impact on any tooling, to my knowledge. Only the first= --- matters for git, any additional ones are ignored. -K