From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84558136353 for ; Fri, 31 Jan 2025 06:22:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738304572; cv=none; b=lJssIboA1BUBdncKlng7Z8vhvsvakxRZax5DzX+nVTaGluullE0skUNxQJeQ4UNBFmb9UY7W3Y8Q661U4IW9MqOdWvqNdvnE8q2TtONvsgkj2RNMP3F4/4mfbIpb0vrqWu3bY8KnWp48ONWlPYOLZMA4El0oFNzIurWy8mVJm8E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738304572; c=relaxed/simple; bh=txktSzkB8qp+h7B6PL4XI68VaK515PGsGP9PT1XlBzs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aJQLf6e7KwbqO8kHtR6LspsD+TpBGyi0NvbqRaQXqDTTX227U+qT2E7c5C0GAfHNB8GHB2qFVH8wOokZwC9v5rATUdg5htWeXK9zbOiojd1XCbYccbSPlvuCZEWh7BR3gg75+erCogvUGHbwmC+OaQGO6zx179bryQvMyGz4yAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ZmNxUlJY; arc=none smtp.client-ip=95.215.58.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ZmNxUlJY" Message-ID: <16e32444-61b0-44f0-9466-b4041dc57267@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1738304558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=txktSzkB8qp+h7B6PL4XI68VaK515PGsGP9PT1XlBzs=; b=ZmNxUlJYHMZ1rhYSA3hiwxINUeEVAOjZWa0GMnN21OpVCny8XY6jQn674Z4yvwi3j1UDI4 ReWLms9BGaWp+hW997jA/MO/WGIw4jAqKbZuk/UTEYdGwK9J4paf77ayVWMrAAhwZeO7Pk silrX2nMGFP8LBtkt6JQbSMsliaLIl8= Date: Thu, 30 Jan 2025 22:22:28 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] selftests: bpf: Support dynamic linking LLVM if static not available Content-Language: en-GB To: Daniel Xu , shuah@kernel.org, andrii@kernel.org, eddyz87@gmail.com, ast@kernel.org, nathan@kernel.org, daniel@iogearbox.net Cc: martin.lau@linux.dev, song@kernel.org, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, mykolal@fb.com, ndesaulniers@google.com, morbo@google.com, justinstitt@google.com, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <872b64e93de9a6cd6a7a10e6a5c5e7893704f743.1738276344.git.dxu@dxuuu.xyz> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: <872b64e93de9a6cd6a7a10e6a5c5e7893704f743.1738276344.git.dxu@dxuuu.xyz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 1/30/25 2:33 PM, Daniel Xu wrote: > Since 67ab80a01886 ("selftests/bpf: Prefer static linking for LLVM > libraries"), only statically linking test_progs is supported. However, > some distros only provide a dynamically linkable LLVM. > > This commit adds a fallback for dynamically linking LLVM if static > linking is not available. If both options are available, static linking > is chosen. > > Signed-off-by: Daniel Xu LGTM. Acked-by: Yonghong Song