* [PATCH net-next] net: dsa: tag_rtl4_a: Use existing ETH_P_REALTEK constant
@ 2023-11-13 16:50 Florian Fainelli
2023-11-13 18:06 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Florian Fainelli @ 2023-11-13 16:50 UTC (permalink / raw)
To: netdev
Cc: Florian Fainelli, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
open list
No functional change, uses the existing ETH_P_REALTEK constant already
defined in if_ether.h.
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
net/dsa/tag_rtl4_a.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/dsa/tag_rtl4_a.c b/net/dsa/tag_rtl4_a.c
index 4da5bad1a7aa..a019226ec6d2 100644
--- a/net/dsa/tag_rtl4_a.c
+++ b/net/dsa/tag_rtl4_a.c
@@ -23,7 +23,6 @@
#define RTL4_A_NAME "rtl4a"
#define RTL4_A_HDR_LEN 4
-#define RTL4_A_ETHERTYPE 0x8899
#define RTL4_A_PROTOCOL_SHIFT 12
/*
* 0x1 = Realtek Remote Control protocol (RRCP)
@@ -54,7 +53,7 @@ static struct sk_buff *rtl4a_tag_xmit(struct sk_buff *skb,
/* Set Ethertype */
p = (__be16 *)tag;
- *p = htons(RTL4_A_ETHERTYPE);
+ *p = htons(ETH_P_REALTEK);
out = (RTL4_A_PROTOCOL_RTL8366RB << RTL4_A_PROTOCOL_SHIFT);
/* The lower bits indicate the port number */
@@ -82,7 +81,7 @@ static struct sk_buff *rtl4a_tag_rcv(struct sk_buff *skb,
tag = dsa_etype_header_pos_rx(skb);
p = (__be16 *)tag;
etype = ntohs(*p);
- if (etype != RTL4_A_ETHERTYPE) {
+ if (etype != ETH_P_REALTEK) {
/* Not custom, just pass through */
netdev_dbg(dev, "non-realtek ethertype 0x%04x\n", etype);
return skb;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: dsa: tag_rtl4_a: Use existing ETH_P_REALTEK constant
2023-11-13 16:50 [PATCH net-next] net: dsa: tag_rtl4_a: Use existing ETH_P_REALTEK constant Florian Fainelli
@ 2023-11-13 18:06 ` Andrew Lunn
2023-11-14 9:02 ` Vladimir Oltean
2023-11-15 3:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2023-11-13 18:06 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, Florian Fainelli, Vladimir Oltean, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, open list
On Mon, Nov 13, 2023 at 08:50:30AM -0800, Florian Fainelli wrote:
> No functional change, uses the existing ETH_P_REALTEK constant already
> defined in if_ether.h.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: dsa: tag_rtl4_a: Use existing ETH_P_REALTEK constant
2023-11-13 16:50 [PATCH net-next] net: dsa: tag_rtl4_a: Use existing ETH_P_REALTEK constant Florian Fainelli
2023-11-13 18:06 ` Andrew Lunn
@ 2023-11-14 9:02 ` Vladimir Oltean
2023-11-15 3:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Vladimir Oltean @ 2023-11-14 9:02 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, Andrew Lunn, Florian Fainelli, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, open list
On Mon, Nov 13, 2023 at 08:50:30AM -0800, Florian Fainelli wrote:
> No functional change, uses the existing ETH_P_REALTEK constant already
> defined in if_ether.h.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: dsa: tag_rtl4_a: Use existing ETH_P_REALTEK constant
2023-11-13 16:50 [PATCH net-next] net: dsa: tag_rtl4_a: Use existing ETH_P_REALTEK constant Florian Fainelli
2023-11-13 18:06 ` Andrew Lunn
2023-11-14 9:02 ` Vladimir Oltean
@ 2023-11-15 3:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-11-15 3:50 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, andrew, f.fainelli, olteanv, davem, edumazet, kuba,
pabeni, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 13 Nov 2023 08:50:30 -0800 you wrote:
> No functional change, uses the existing ETH_P_REALTEK constant already
> defined in if_ether.h.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
> net/dsa/tag_rtl4_a.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Here is the summary with links:
- [net-next] net: dsa: tag_rtl4_a: Use existing ETH_P_REALTEK constant
https://git.kernel.org/netdev/net-next/c/8fedaaca4071
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-15 3:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-13 16:50 [PATCH net-next] net: dsa: tag_rtl4_a: Use existing ETH_P_REALTEK constant Florian Fainelli
2023-11-13 18:06 ` Andrew Lunn
2023-11-14 9:02 ` Vladimir Oltean
2023-11-15 3:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox