From: patchwork-bot+netdevbpf@kernel.org
To: Jann Horn <jannh@google.com>
Cc: borisp@nvidia.com, john.fastabend@gmail.com, kuba@kernel.org,
davem@davemloft.net, dhowells@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] tls: fix NULL deref on tls_sw_splice_eof() with empty record
Date: Thu, 23 Nov 2023 17:00:26 +0000 [thread overview]
Message-ID: <170075882659.541.15438374448743865458.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20231122214447.675768-1-jannh@google.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 22 Nov 2023 22:44:47 +0100 you wrote:
> syzkaller discovered that if tls_sw_splice_eof() is executed as part of
> sendfile() when the plaintext/ciphertext sk_msg are empty, the send path
> gets confused because the empty ciphertext buffer does not have enough
> space for the encryption overhead. This causes tls_push_record() to go on
> the `split = true` path (which is only supposed to be used when interacting
> with an attached BPF program), and then get further confused and hit the
> tls_merge_open_record() path, which then assumes that there must be at
> least one populated buffer element, leading to a NULL deref.
>
> [...]
Here is the summary with links:
- [net] tls: fix NULL deref on tls_sw_splice_eof() with empty record
https://git.kernel.org/netdev/net/c/53f2cb491b50
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2023-11-23 17:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 21:44 [PATCH net] tls: fix NULL deref on tls_sw_splice_eof() with empty record Jann Horn
2023-11-22 21:58 ` Jann Horn
2023-11-26 23:56 ` John Fastabend
2023-11-23 17:00 ` patchwork-bot+netdevbpf [this message]
2023-11-27 9:04 ` David Howells
2023-11-27 13:10 ` Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170075882659.541.15438374448743865458.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=jannh@google.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox