Re: [PATCH v3 28/33] fprobe: Rewrite fprobe on function-graph tracer

Masami Hiramatsu
2023-11-28T12:23:00Z

On Tue, 28 Nov 2023 11:53:19 +0100
Jiri Olsa <olsajiri@gmail.com> wrote:

> On Mon, Nov 27, 2023 at 10:58:40PM +0900, Masami Hiramatsu (Google) wrote:
> > From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> >
> > Rewrite fprobe implementation on function-graph tracer.
> > Major API changes are:
> > - 'nr_maxactive' field is deprecated.
> > - This depends on CONFIG_DYNAMIC_FTRACE_WITH_ARGS or
> > !CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS, and
> > CONFIG_HAVE_FUNCTION_GRAPH_FREGS. So currently works only
> > on x86_64.
> > - Currently the entry size is limited in 15 * sizeof(long).
> > - If there is too many fprobe exit handler set on the same
> > function, it will fail to probe.
> >
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > ---
> > Changes in v3:
> > - Update for new reserve_data/retrieve_data API.
> > - Fix internal push/pop on fgraph data logic so that it can
> > correctly save/restore the returning fprobes.
>
> hi,
> looks like this one conflicts with recent:
>
> 4bbd93455659 kprobes: kretprobe scalability improvement

Thanks for reporting!

I also found some other patches conflicts with recent commits.
Let me rebase it on the recent branch.

Thank!

>
> jirka

--
Masami Hiramatsu (Google) <mhiramat@kernel.org>