* [PATCH net-next v1 1/1] net: dsa: sja1105: Use units.h instead of the copy of a definition
@ 2023-11-28 17:50 Andy Shevchenko
2023-11-29 12:19 ` Vladimir Oltean
2023-11-30 4:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2023-11-28 17:50 UTC (permalink / raw)
To: Vladimir Oltean, linux-kernel, netdev
Cc: Vladimir Oltean, Andrew Lunn, Florian Fainelli, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Andy Shevchenko
BYTES_PER_KBIT is defined in units.h, use that definition.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/dsa/sja1105/sja1105_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
index 74cee39d73df..6646f7fb0f90 100644
--- a/drivers/net/dsa/sja1105/sja1105_main.c
+++ b/drivers/net/dsa/sja1105/sja1105_main.c
@@ -21,6 +21,8 @@
#include <linux/if_bridge.h>
#include <linux/if_ether.h>
#include <linux/dsa/8021q.h>
+#include <linux/units.h>
+
#include "sja1105.h"
#include "sja1105_tas.h"
@@ -2138,7 +2140,6 @@ static void sja1105_bridge_leave(struct dsa_switch *ds, int port,
sja1105_bridge_member(ds, port, bridge, false);
}
-#define BYTES_PER_KBIT (1000LL / 8)
/* Port 0 (the uC port) does not have CBS shapers */
#define SJA1110_FIXED_CBS(port, prio) ((((port) - 1) * SJA1105_NUM_TC) + (prio))
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v1 1/1] net: dsa: sja1105: Use units.h instead of the copy of a definition
2023-11-28 17:50 [PATCH net-next v1 1/1] net: dsa: sja1105: Use units.h instead of the copy of a definition Andy Shevchenko
@ 2023-11-29 12:19 ` Vladimir Oltean
2023-11-30 4:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Oltean @ 2023-11-29 12:19 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-kernel, netdev, Vladimir Oltean, Andrew Lunn,
Florian Fainelli, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
On Tue, Nov 28, 2023 at 07:50:27PM +0200, Andy Shevchenko wrote:
> BYTES_PER_KBIT is defined in units.h, use that definition.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v1 1/1] net: dsa: sja1105: Use units.h instead of the copy of a definition
2023-11-28 17:50 [PATCH net-next v1 1/1] net: dsa: sja1105: Use units.h instead of the copy of a definition Andy Shevchenko
2023-11-29 12:19 ` Vladimir Oltean
@ 2023-11-30 4:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-11-30 4:20 UTC (permalink / raw)
To: Andy Shevchenko
Cc: vladimir.oltean, linux-kernel, netdev, olteanv, andrew,
f.fainelli, davem, edumazet, kuba, pabeni
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 28 Nov 2023 19:50:27 +0200 you wrote:
> BYTES_PER_KBIT is defined in units.h, use that definition.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/net/dsa/sja1105/sja1105_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Here is the summary with links:
- [net-next,v1,1/1] net: dsa: sja1105: Use units.h instead of the copy of a definition
https://git.kernel.org/netdev/net-next/c/4b86d7c64e8f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-30 4:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28 17:50 [PATCH net-next v1 1/1] net: dsa: sja1105: Use units.h instead of the copy of a definition Andy Shevchenko
2023-11-29 12:19 ` Vladimir Oltean
2023-11-30 4:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox