* [PATCH] bpf/tests: Remove duplicate JSGT tests
@ 2023-11-30 3:40 Yujie Liu
2023-11-30 11:06 ` Johan Almbladh
2023-11-30 11:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Yujie Liu @ 2023-11-30 3:40 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, Johan Almbladh, bpf; +Cc: linux-kernel
It seems unnecessary that JSGT is tested twice (one before JSGE and one
after JSGE) since others are tested only once. Remove the duplicate JSGT
tests.
Fixes: 0bbaa02b4816 ("bpf/tests: Add tests to check source register zero-extension")
Signed-off-by: Yujie Liu <yujie.liu@intel.com>
---
lib/test_bpf.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/test_bpf.c b/lib/test_bpf.c
index 7916503e6a6a..87a4ebcc65be 100644
--- a/lib/test_bpf.c
+++ b/lib/test_bpf.c
@@ -12215,7 +12215,6 @@ static struct bpf_test tests[] = {
BPF_JMP32_IMM_ZEXT(JLE),
BPF_JMP32_IMM_ZEXT(JSGT),
BPF_JMP32_IMM_ZEXT(JSGE),
- BPF_JMP32_IMM_ZEXT(JSGT),
BPF_JMP32_IMM_ZEXT(JSLT),
BPF_JMP32_IMM_ZEXT(JSLE),
#undef BPF_JMP2_IMM_ZEXT
@@ -12251,7 +12250,6 @@ static struct bpf_test tests[] = {
BPF_JMP32_REG_ZEXT(JLE),
BPF_JMP32_REG_ZEXT(JSGT),
BPF_JMP32_REG_ZEXT(JSGE),
- BPF_JMP32_REG_ZEXT(JSGT),
BPF_JMP32_REG_ZEXT(JSLT),
BPF_JMP32_REG_ZEXT(JSLE),
#undef BPF_JMP2_REG_ZEXT
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] bpf/tests: Remove duplicate JSGT tests
2023-11-30 3:40 [PATCH] bpf/tests: Remove duplicate JSGT tests Yujie Liu
@ 2023-11-30 11:06 ` Johan Almbladh
2023-11-30 11:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Johan Almbladh @ 2023-11-30 11:06 UTC (permalink / raw)
To: Yujie Liu; +Cc: Alexei Starovoitov, Daniel Borkmann, bpf, linux-kernel
On Thu, Nov 30, 2023 at 4:44 AM Yujie Liu <yujie.liu@intel.com> wrote:
>
> It seems unnecessary that JSGT is tested twice (one before JSGE and one
> after JSGE) since others are tested only once. Remove the duplicate JSGT
> tests.
Looks like a copy-paste typo on my side. Thanks!
Acked-by: Johan Almbladh <johan.almbladh@anyfinetworks.com>
>
> Fixes: 0bbaa02b4816 ("bpf/tests: Add tests to check source register zero-extension")
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>
> ---
> lib/test_bpf.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lib/test_bpf.c b/lib/test_bpf.c
> index 7916503e6a6a..87a4ebcc65be 100644
> --- a/lib/test_bpf.c
> +++ b/lib/test_bpf.c
> @@ -12215,7 +12215,6 @@ static struct bpf_test tests[] = {
> BPF_JMP32_IMM_ZEXT(JLE),
> BPF_JMP32_IMM_ZEXT(JSGT),
> BPF_JMP32_IMM_ZEXT(JSGE),
> - BPF_JMP32_IMM_ZEXT(JSGT),
> BPF_JMP32_IMM_ZEXT(JSLT),
> BPF_JMP32_IMM_ZEXT(JSLE),
> #undef BPF_JMP2_IMM_ZEXT
> @@ -12251,7 +12250,6 @@ static struct bpf_test tests[] = {
> BPF_JMP32_REG_ZEXT(JLE),
> BPF_JMP32_REG_ZEXT(JSGT),
> BPF_JMP32_REG_ZEXT(JSGE),
> - BPF_JMP32_REG_ZEXT(JSGT),
> BPF_JMP32_REG_ZEXT(JSLT),
> BPF_JMP32_REG_ZEXT(JSLE),
> #undef BPF_JMP2_REG_ZEXT
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] bpf/tests: Remove duplicate JSGT tests
2023-11-30 3:40 [PATCH] bpf/tests: Remove duplicate JSGT tests Yujie Liu
2023-11-30 11:06 ` Johan Almbladh
@ 2023-11-30 11:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-11-30 11:20 UTC (permalink / raw)
To: Yujie Liu; +Cc: ast, daniel, johan.almbladh, bpf, linux-kernel
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:
On Thu, 30 Nov 2023 11:40:18 +0800 you wrote:
> It seems unnecessary that JSGT is tested twice (one before JSGE and one
> after JSGE) since others are tested only once. Remove the duplicate JSGT
> tests.
>
> Fixes: 0bbaa02b4816 ("bpf/tests: Add tests to check source register zero-extension")
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>
>
> [...]
Here is the summary with links:
- bpf/tests: Remove duplicate JSGT tests
https://git.kernel.org/bpf/bpf-next/c/f690ff9122d2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-30 11:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-30 3:40 [PATCH] bpf/tests: Remove duplicate JSGT tests Yujie Liu
2023-11-30 11:06 ` Johan Almbladh
2023-11-30 11:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox