From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1866C4167B for ; Mon, 4 Dec 2023 12:30:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344025AbjLDMa0 (ORCPT ); Mon, 4 Dec 2023 07:30:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235415AbjLDMaS (ORCPT ); Mon, 4 Dec 2023 07:30:18 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45D8B116 for ; Mon, 4 Dec 2023 04:30:25 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPS id CF709C433C8; Mon, 4 Dec 2023 12:30:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701693024; bh=Scnnbxct6A0XPzh5s73Wc9TuJRZ1k4HhysjpASGiM/M=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=VwNBAhM3Q1gjAVS8rMJVe7C3EGqC71Xb41c+pR4K4W2naiCy4nJh46gxiocwEGbKB OuscaGrW9kFb0SgGYGGcERJV3JbEqfNQVxgUYC5ZH/0EgMbdBmyxA8snNBagLAfRcT F8UxarbIUQ/YUctZZq+hwmpZK37/xXqKqOvCcxy1AQKppTcn10wDB0CUqrFpysLVGt v9zKu8p8SKS4MuskqiZjHjL2v1x8z1FLHho1DmfpAQ5m+CbrYqWCCC8hKnQGj8FhSZ +adRCFwQVUfAgS2gfGVEAm3RwON6SObRutdLZrRBVrgYz+QjCzmxktZw7+njTU6rgB UzCDo1VWusPMQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id B154CDD4EEF; Mon, 4 Dec 2023 12:30:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v3 1/5] r8152: Hold the rtnl_lock for all of reset From: patchwork-bot+netdevbpf@kernel.org Message-Id: <170169302472.7913.15839516677330615990.git-patchwork-notify@kernel.org> Date: Mon, 04 Dec 2023 12:30:24 +0000 References: <20231129132521.net.v3.1.I77097aa9ec01aeca1b3c75fde4ba5007a17fdf76@changeid> In-Reply-To: <20231129132521.net.v3.1.I77097aa9ec01aeca1b3c75fde4ba5007a17fdf76@changeid> To: Doug Anderson Cc: kuba@kernel.org, hayeswang@realtek.com, davem@davemloft.net, linux-usb@vger.kernel.org, grundler@chromium.org, laura.nao@collabora.com, ecgh@chromium.org, stern@rowland.harvard.edu, horms@kernel.org, bjorn@mork.no, edumazet@google.com, pabeni@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This series was applied to netdev/net.git (main) by David S. Miller : On Wed, 29 Nov 2023 13:25:20 -0800 you wrote: > As of commit d9962b0d4202 ("r8152: Block future register access if > register access fails") there is a race condition that can happen > between the USB device reset thread and napi_enable() (not) getting > called during rtl8152_open(). Specifically: > * While rtl8152_open() is running we get a register access error > that's _not_ -ENODEV and queue up a USB reset. > * rtl8152_open() exits before calling napi_enable() due to any reason > (including usb_submit_urb() returning an error). > > [...] Here is the summary with links: - [net,v3,1/5] r8152: Hold the rtnl_lock for all of reset https://git.kernel.org/netdev/net/c/e62adaeecdc6 - [net,v3,2/5] r8152: Add RTL8152_INACCESSIBLE checks to more loops https://git.kernel.org/netdev/net/c/32a574c7e268 - [net,v3,3/5] r8152: Add RTL8152_INACCESSIBLE to r8156b_wait_loading_flash() https://git.kernel.org/netdev/net/c/8a67b47fced9 - [net,v3,4/5] r8152: Add RTL8152_INACCESSIBLE to r8153_pre_firmware_1() https://git.kernel.org/netdev/net/c/8c53a7bd7065 - [net,v3,5/5] r8152: Add RTL8152_INACCESSIBLE to r8153_aldps_en() https://git.kernel.org/netdev/net/c/79321a793945 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html