[PATCH RESEND bpf-next v1] test_bpf: Rename second ALU64_SMOD_X to ALU64_SMOD_K

[PATCH RESEND bpf-next v1] test_bpf: Rename second ALU64_SMOD_X to ALU64_SMOD_K

[Tiezhu Yang]

Currently, there are two test cases with same name
"ALU64_SMOD_X: -7 % 2 = -1", the first one is right,
the second one should be ALU64_SMOD_K because its
code is BPF_ALU64 | BPF_MOD | BPF_K.

Before:
test_bpf: #170 ALU64_SMOD_X: -7 % 2 = -1 jited:1 4 PASS
test_bpf: #171 ALU64_SMOD_X: -7 % 2 = -1 jited:1 4 PASS

After:
test_bpf: #170 ALU64_SMOD_X: -7 % 2 = -1 jited:1 4 PASS
test_bpf: #171 ALU64_SMOD_K: -7 % 2 = -1 jited:1 4 PASS

Fixes: daabb2b098e0 ("bpf/tests: add tests for cpuv4 instructions")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---

Add "bpf-next" in the patch subject, sorry for that

 lib/test_bpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_bpf.c b/lib/test_bpf.c
index 7916503e6a6a..3c5a1ca06219 100644
--- a/lib/test_bpf.c
+++ b/lib/test_bpf.c
@@ -6293,7 +6293,7 @@ static struct bpf_test tests[] = {
 	},
 	/* BPF_ALU64 | BPF_MOD | BPF_K off=1 (SMOD64) */
 	{
-		"ALU64_SMOD_X: -7 % 2 = -1",
+		"ALU64_SMOD_K: -7 % 2 = -1",
 		.u.insns_int = {
 			BPF_LD_IMM64(R0, -7),
 			BPF_ALU64_IMM_OFF(BPF_MOD, R0, 2, 1),
-- 
2.42.0

Re: [PATCH RESEND bpf-next v1] test_bpf: Rename second ALU64_SMOD_X to ALU64_SMOD_K

[Yonghong Song]

On 12/6/23 11:08 PM, Tiezhu Yang wrote:
> Currently, there are two test cases with same name
> "ALU64_SMOD_X: -7 % 2 = -1", the first one is right,
> the second one should be ALU64_SMOD_K because its
> code is BPF_ALU64 | BPF_MOD | BPF_K.
>
> Before:
> test_bpf: #170 ALU64_SMOD_X: -7 % 2 = -1 jited:1 4 PASS
> test_bpf: #171 ALU64_SMOD_X: -7 % 2 = -1 jited:1 4 PASS
>
> After:
> test_bpf: #170 ALU64_SMOD_X: -7 % 2 = -1 jited:1 4 PASS
> test_bpf: #171 ALU64_SMOD_K: -7 % 2 = -1 jited:1 4 PASS
>
> Fixes: daabb2b098e0 ("bpf/tests: add tests for cpuv4 instructions")
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

Acked-by: Yonghong Song <yonghong.song@linux.dev>

Re: [PATCH RESEND bpf-next v1] test_bpf: Rename second ALU64_SMOD_X to ALU64_SMOD_K

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Thu,  7 Dec 2023 12:08:51 +0800 you wrote:
> Currently, there are two test cases with same name
> "ALU64_SMOD_X: -7 % 2 = -1", the first one is right,
> the second one should be ALU64_SMOD_K because its
> code is BPF_ALU64 | BPF_MOD | BPF_K.
> 
> Before:
> test_bpf: #170 ALU64_SMOD_X: -7 % 2 = -1 jited:1 4 PASS
> test_bpf: #171 ALU64_SMOD_X: -7 % 2 = -1 jited:1 4 PASS
> 
> [...]

Here is the summary with links:
  - [RESEND,bpf-next,v1] test_bpf: Rename second ALU64_SMOD_X to ALU64_SMOD_K
    https://git.kernel.org/bpf/bpf-next/c/5181dc08f795

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html