From: Arnd Bergmann <arnd@arndb.de>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, Corey Minyard <cminyard@mvista.com>,
Stanislav Meduna <stano@meduna.org>
Subject: Re: [PATCH v2] tracing: Don't account for cpu idle time with irqsoff tracers
Date: Tue, 27 May 2014 22:11:25 +0200 [thread overview]
Message-ID: <17051981.niWmA6MIgX@wuerfel> (raw)
In-Reply-To: <1401221284-13678-1-git-send-email-sboyd@codeaurora.org>
On Tuesday 27 May 2014 13:08:04 Stephen Boyd wrote:
> @@ -380,7 +382,7 @@ start_critical_timing(unsigned long ip, unsigned long parent_ip)
>
> cpu = raw_smp_processor_id();
>
> - if (per_cpu(tracing_cpu, cpu))
> + if (per_cpu(timings_stopped, cpu) || per_cpu(tracing_cpu, cpu))
> return;
>
> data = per_cpu_ptr(tr->trace_buffer.data, cpu);
>
Where exactly do you see other code calling here while
per_cpu(timings_stopped) is set? Would it be possible to just
change that call site?
Arnd
next prev parent reply other threads:[~2014-05-27 20:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 20:08 [PATCH v2] tracing: Don't account for cpu idle time with irqsoff tracers Stephen Boyd
2014-05-27 20:11 ` Arnd Bergmann [this message]
2014-05-27 21:48 ` Steven Rostedt
2014-05-27 22:21 ` Stephen Boyd
2014-05-27 23:30 ` Steven Rostedt
2014-05-28 0:11 ` Stephen Boyd
2014-05-28 0:23 ` Stephen Boyd
2014-05-28 0:42 ` Steven Rostedt
2014-05-28 7:24 ` Peter Zijlstra
2014-05-28 17:22 ` John Stultz
2014-05-28 0:25 ` Paul E. McKenney
2014-05-28 6:40 ` Arnd Bergmann
2014-05-28 6:44 ` Arnd Bergmann
2014-05-28 7:28 ` Peter Zijlstra
2014-05-28 14:09 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17051981.niWmA6MIgX@wuerfel \
--to=arnd@arndb.de \
--cc=cminyard@mvista.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sboyd@codeaurora.org \
--cc=stano@meduna.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox