From: patchwork-bot+netdevbpf@kernel.org
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
s.shtylyov@omp.ru, claudiu.beznea.uj@bp.renesas.com,
yoshihiro.shimoda.uh@renesas.com,
wsa+renesas@sang-engineering.com, u.kleine-koenig@pengutronix.de,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ravb: Fix dma_addr_t truncation in error case
Date: Sun, 14 Jan 2024 16:50:24 +0000 [thread overview]
Message-ID: <170525102408.11320.1615500877884972571.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240113042221.480650-1-nikita.yoush@cogentembedded.com>
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Sat, 13 Jan 2024 10:22:21 +0600 you wrote:
> In ravb_start_xmit(), ravb driver uses u32 variable to store result of
> dma_map_single() call. Since ravb hardware has 32-bit address fields in
> descriptors, this works properly when mapping is successful - it is
> platform's job to provide mapping addresses that fit into hardware
> limitations.
>
> However, in failure case dma_map_single() returns DMA_MAPPING_ERROR
> constant that is 64-bit when dma_addr_t is 64-bit. Storing this constant
> in u32 leads to truncation, and further call to dma_mapping_error()
> fails to notice the error.
>
> [...]
Here is the summary with links:
- net: ravb: Fix dma_addr_t truncation in error case
https://git.kernel.org/netdev/net/c/e327b2372bc0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-01-14 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-13 4:22 [PATCH] net: ravb: Fix dma_addr_t truncation in error case Nikita Yushchenko
2024-01-13 8:31 ` Niklas Söderlund
2024-01-13 9:43 ` Sergey Shtylyov
2024-01-13 21:03 ` Florian Fainelli
2024-01-14 16:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170525102408.11320.1615500877884972571.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=pabeni@redhat.com \
--cc=s.shtylyov@omp.ru \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox