From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933920AbbDXH3Q (ORCPT ); Fri, 24 Apr 2015 03:29:16 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:53730 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933623AbbDXH3O (ORCPT ); Fri, 24 Apr 2015 03:29:14 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Feng Kan , patches@apm.com, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH V3 2/4] i2c: busses: xgene: add acpi support for i2c xgene SLIMpro driver Date: Fri, 24 Apr 2015 09:28:40 +0200 Message-ID: <17062291.7gO4LEY2iX@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1429812430-31631-3-git-send-email-fkan@apm.com> References: <1429812430-31631-1-git-send-email-fkan@apm.com> <1429812430-31631-3-git-send-email-fkan@apm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:PeyHjOSAdLVZG9TV3pel8CxnT8Vr25b11ZB+SbYE6aC6xXaHdZ4 a4UQm3ZeeMAP1Ls8QZ1TQslCKrSqdjUQ0Mvx01EH57SVQFTM1+YxIMR+tmsIQe+fE5ENqpV JPEzq/fp9OqOf+jJdRsiLgODMNpq3PAGAx3d5ouYfDhrEaWpUf27c6WMQIWBe4NoYAjC3Ra ZZJ36GPKuc3y+ohxYmbuQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 23 April 2015 11:07:08 Feng Kan wrote: > > +#ifdef CONFIG_ACPI > +static const struct acpi_device_id xgene_slimpro_i2c_acpi_ids[] = { > + {"PRP0001", 0}, > + {} > +}; > +MODULE_DEVICE_TABLE(acpi, slimpro_acpi_ids); > +#endif > Sorry, but this is wrong: The PRP0001 name is meant for embedded devices that just use the generic properties API for loading, and does not require specifying an ACPI device ID. Arnd