[PATCH bpf-next] selftests/bpf: Add missing line break in test_verifier

[PATCH bpf-next] selftests/bpf: Add missing line break in test_verifier

[Tiezhu Yang]

There are no break lines in the test log for test_verifier #106 ~ #111
if jit is disabled, add the missing line break at the end of printf()
to fix it.

Without this patch:

  [root@linux bpf]# echo 0 > /proc/sys/net/core/bpf_jit_enable
  [root@linux bpf]# ./test_verifier 106
  #106/p inline simple bpf_loop call SKIP (requires BPF JIT)Summary: 0 PASSED, 1 SKIPPED, 0 FAILED

With this patch:

  [root@linux bpf]# echo 0 > /proc/sys/net/core/bpf_jit_enable
  [root@linux bpf]# ./test_verifier 106
  #106/p inline simple bpf_loop call SKIP (requires BPF JIT)
  Summary: 0 PASSED, 1 SKIPPED, 0 FAILED

Fixes: 0b50478fd877 ("selftests/bpf: Skip callback tests if jit is disabled in test_verifier")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---

I am not sure whether the Fixes tag is necessary, you can remove it
if it is useless, thank you.

 tools/testing/selftests/bpf/test_verifier.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/test_verifier.c
index e1a1dfe8d7fa..df04bda1c927 100644
--- a/tools/testing/selftests/bpf/test_verifier.c
+++ b/tools/testing/selftests/bpf/test_verifier.c
@@ -1527,7 +1527,7 @@ static void do_test_single(struct bpf_test *test, bool unpriv,
 	int i, err;
 
 	if ((test->flags & F_NEEDS_JIT_ENABLED) && jit_disabled) {
-		printf("SKIP (requires BPF JIT)");
+		printf("SKIP (requires BPF JIT)\n");
 		skips++;
 		sched_yield();
 		return;
-- 
2.42.0

Re: [PATCH bpf-next] selftests/bpf: Add missing line break in test_verifier

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Fri, 26 Jan 2024 09:57:36 +0800 you wrote:
> There are no break lines in the test log for test_verifier #106 ~ #111
> if jit is disabled, add the missing line break at the end of printf()
> to fix it.
> 
> Without this patch:
> 
>   [root@linux bpf]# echo 0 > /proc/sys/net/core/bpf_jit_enable
>   [root@linux bpf]# ./test_verifier 106
>   #106/p inline simple bpf_loop call SKIP (requires BPF JIT)Summary: 0 PASSED, 1 SKIPPED, 0 FAILED
> 
> [...]

Here is the summary with links:
  - [bpf-next] selftests/bpf: Add missing line break in test_verifier
    https://git.kernel.org/bpf/bpf-next/c/fa7178b0f12e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html