public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Kees Cook <keescook@chromium.org>
Cc: aelior@marvell.com, lkp@intel.com, skalluru@marvell.com,
	manishc@marvell.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] bnx2x: Fix firmware version string character counts
Date: Sat, 27 Jan 2024 05:10:29 +0000	[thread overview]
Message-ID: <170633222947.22327.17115220484623160383.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240126041044.work.220-kees@kernel.org>

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 25 Jan 2024 20:10:48 -0800 you wrote:
> A potential string truncation was reported in bnx2x_fill_fw_str(),
> when a long bp->fw_ver and a long phy_fw_ver might coexist, but seems
> unlikely with real-world hardware.
> 
> Use scnprintf() to indicate the intent that truncations are tolerated.
> 
> While reading this code, I found a collection of various buffer size
> counting issues. None looked like they might lead to a buffer overflow
> with current code (the small buffers are 20 bytes and might only ever
> consume 10 bytes twice with a trailing %NUL). However, early truncation
> (due to a %NUL in the middle of the string) might be happening under
> likely rare conditions. Regardless fix the formatters and related
> functions:
> 
> [...]

Here is the summary with links:
  - bnx2x: Fix firmware version string character counts
    https://git.kernel.org/netdev/net-next/c/5642c82b9463

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      reply	other threads:[~2024-01-27  5:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-26  4:10 [PATCH] bnx2x: Fix firmware version string character counts Kees Cook
2024-01-27  5:10 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170633222947.22327.17115220484623160383.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=aelior@marvell.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=manishc@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=skalluru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox