* [PATCH] qed: remove duplicated assignment to variable opaque_fid
@ 2024-02-05 21:55 Colin Ian King
2024-02-07 9:39 ` Simon Horman
2024-02-09 3:11 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2024-02-05 21:55 UTC (permalink / raw)
To: Ariel Elior, Manish Chopra, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev
Cc: kernel-janitors, linux-kernel
Variable opaque_fid is being assigned twice with the same value
in two identical statements. Remove the redundant first assignment.
Cleans up clang scan build warnin:
drivers/net/ethernet/qlogic/qed/qed_rdma.c:1796:2: warning: Value
stored to 'opaque_fid' is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/ethernet/qlogic/qed/qed_rdma.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
index 5a5dbbb8d8aa..9a1660a12c57 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
@@ -1793,8 +1793,6 @@ qed_rdma_create_srq(void *rdma_cxt,
if (rc)
goto err;
- opaque_fid = p_hwfn->hw_info.opaque_fid;
-
opaque_fid = p_hwfn->hw_info.opaque_fid;
init_data.opaque_fid = opaque_fid;
init_data.comp_mode = QED_SPQ_MODE_EBLOCK;
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qed: remove duplicated assignment to variable opaque_fid
2024-02-05 21:55 [PATCH] qed: remove duplicated assignment to variable opaque_fid Colin Ian King
@ 2024-02-07 9:39 ` Simon Horman
2024-02-09 3:11 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-02-07 9:39 UTC (permalink / raw)
To: Colin Ian King
Cc: Ariel Elior, Manish Chopra, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, kernel-janitors,
linux-kernel
On Mon, Feb 05, 2024 at 09:55:30PM +0000, Colin Ian King wrote:
> Variable opaque_fid is being assigned twice with the same value
> in two identical statements. Remove the redundant first assignment.
>
> Cleans up clang scan build warnin:
warning :)
> drivers/net/ethernet/qlogic/qed/qed_rdma.c:1796:2: warning: Value
> stored to 'opaque_fid' is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qed: remove duplicated assignment to variable opaque_fid
2024-02-05 21:55 [PATCH] qed: remove duplicated assignment to variable opaque_fid Colin Ian King
2024-02-07 9:39 ` Simon Horman
@ 2024-02-09 3:11 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-09 3:11 UTC (permalink / raw)
To: Colin Ian King
Cc: aelior, manishc, davem, edumazet, kuba, pabeni, netdev,
kernel-janitors, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 5 Feb 2024 21:55:30 +0000 you wrote:
> Variable opaque_fid is being assigned twice with the same value
> in two identical statements. Remove the redundant first assignment.
>
> Cleans up clang scan build warnin:
> drivers/net/ethernet/qlogic/qed/qed_rdma.c:1796:2: warning: Value
> stored to 'opaque_fid' is never read [deadcode.DeadStores]
>
> [...]
Here is the summary with links:
- qed: remove duplicated assignment to variable opaque_fid
https://git.kernel.org/netdev/net-next/c/5c80e62a2ac5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-09 3:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-05 21:55 [PATCH] qed: remove duplicated assignment to variable opaque_fid Colin Ian King
2024-02-07 9:39 ` Simon Horman
2024-02-09 3:11 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).