Re: [PATCH net-next] net: dsa: realtek: fix digital interface select macro for EXT0

Alvin Šipraga
2024-02-12T22:11:44Z

On Mon, Feb 12, 2024 at 06:34:33PM -0300, Luiz Angelo Daros de Luca wrote:
> While no supported devices currently utilize EXT0, the register reserves
> the bits for an EXT0. EXT0 is utilized by devices from the generation
> prior to rtl8365mb, such as those supported by the driver library
> rtl8367b.
>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> ---

Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>

> drivers/net/dsa/realtek/rtl8365mb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c
> index be56373e9473..12665a8a3412 100644
> --- a/drivers/net/dsa/realtek/rtl8365mb.c
> +++ b/drivers/net/dsa/realtek/rtl8365mb.c
> @@ -209,10 +209,10 @@
> #define RTL8365MB_EXT_PORT_MODE_100FX 13
>
> /* External interface mode configuration registers 0~1 */
> -#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 0x1305 /* EXT1 */
> +#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 0x1305 /* EXT0,EXT1 */
> #define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG1 0x13C3 /* EXT2 */
> #define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG(_extint) \
> - ((_extint) == 1 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 : \
> + ((_extint) <= 1 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 : \
> (_extint) == 2 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG1 : \
> 0x0)
> #define RTL8365MB_DIGITAL_INTERFACE_SELECT_MODE_MASK(_extint) \
>
> ---
> base-commit: 0f37666d87d2dea42ec21776c3d562b7cbd71612
> change-id: 20240212-realtek-fix_ext0-804aa3272a76
>
> Best regards,
> --
> Luiz Angelo Daros de Luca <luizluca@gmail.com>
>