Re: [PATCH net v2 5/9] net: fill in MODULE_DESCRIPTION()s for ipv6 modules

Simon Horman
2024-02-07T11:33:15Z

On Wed, Feb 07, 2024 at 02:19:24AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the IPv6 modules.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>

...

> index a7bf0327b380..8820bf5b101a 100644
> --- a/net/ipv6/ip6_udp_tunnel.c
> +++ b/net/ipv6/ip6_udp_tunnel.c
> @@ -182,4 +182,5 @@ struct dst_entry *udp_tunnel6_dst_lookup(struct sk_buff *skb,
> }
> EXPORT_SYMBOL_GPL(udp_tunnel6_dst_lookup);
>
> +MODULE_DESCRIPTION("IPv6 UDP tunnel driver");
> MODULE_LICENSE("GPL");

Hi Breno,

I don't feel strongly about this,
but looking at NET_UDP_TUNNEL and NET_FOU in net/ipv4/Kconfig, maybe:

IPv6 Foo over UDP tunnel driver

Likewise for the change to net/ipv4/udp_tunnel_core.c
in the following patch.

The above not withstanding, this looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>

...