Re: [BK PATCH] CIFS filesystem for Linux 2.5

Andi Kleen
2002-10-10T21:54:50Z

David Woodhouse <dwmw2@infradead.org> writes:

> sfrench@us.ibm.com said:
> > fs/cifs/md4.c | 209 +++
> > fs/cifs/md5.c | 363 +++++
> > fs/cifs/md5.h | 38
>
> Unless these are somehow CIFS-specific, they should live in linux/lib/

This would have the disadvantage that they would need to be always compiled into the
kernel, even though it may not need it. And we already have code bloat problems,
no need to make it worse.

Making them modular also isn't good. Each module takes a 4k page at least, so you
would waste a lot of memory because they're smaller than 4k.

As long as they are not used by anything else it's probably best to keep it
where they are.

-Andi