From: patchwork-bot+netdevbpf@kernel.org
To: Yewon Choi <woni9911@gmail.com>
Cc: allison.henderson@oracle.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
threeearcat@gmail.com
Subject: Re: [PATCH net v2] rds: introduce acquire/release ordering in acquire/release_in_xmit()
Date: Tue, 19 Mar 2024 11:30:27 +0000 [thread overview]
Message-ID: <171084782780.9693.3451064874189878588.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <ZfQUxnNTO9AJmzwc@libra05>
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 15 Mar 2024 18:28:38 +0900 you wrote:
> acquire/release_in_xmit() work as bit lock in rds_send_xmit(), so they
> are expected to ensure acquire/release memory ordering semantics.
> However, test_and_set_bit/clear_bit() don't imply such semantics, on
> top of this, following smp_mb__after_atomic() does not guarantee release
> ordering (memory barrier actually should be placed before clear_bit()).
>
> Instead, we use clear_bit_unlock/test_and_set_bit_lock() here.
>
> [...]
Here is the summary with links:
- [net,v2] rds: introduce acquire/release ordering in acquire/release_in_xmit()
https://git.kernel.org/netdev/net/c/1422f28826d2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-03-19 11:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 9:28 [PATCH net v2] rds: introduce acquire/release ordering in acquire/release_in_xmit() Yewon Choi
2024-03-15 13:32 ` Michal Kubiak
2024-03-19 11:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171084782780.9693.3451064874189878588.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
--cc=threeearcat@gmail.com \
--cc=woni9911@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox