Re: [PATCH v3 2/3] watchdog: Add ChromeOS EC-based watchdog driver

Łukasz Majczak
2024-01-22T15:09:44Z

On Mon, Jan 22, 2024 at 11:31 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > + wdd = devm_kzalloc(&pdev->dev, sizeof(struct watchdog_device), GFP_KERNEL);
>
> sizeof(*)
>
ACK.

> > +MODULE_DEVICE_TABLE(platform, cros_ec_wdt_id);
>
> device_id is not placed here, please open existing drivers for
> reference. Why this isn't referenced in driver structure?
>
ACK, I will take s3c2410_wdt.c as an example, thank you.

Best regards,
Lukasz