Re: [PATCH net-next v3] tg3: Remove residual error handling in tg3_suspend

Pavan Chebbi
2024-07-10T04:53:29Z

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]

On Tue, Jul 9, 2024 at 10:24 PM Nikita Kiryushin <kiryushin@ancud.ru> wrote:
>
> As of now, tg3_power_down_prepare always ends with success, but
> the error handling code from former tg3_set_power_state call is still here.
>
> This code became unreachable in commit c866b7eac073 ("tg3: Do not use
> legacy PCI power management").
>
> Remove (now unreachable) error handling code for simplification and change
> tg3_power_down_prepare to a void function as its result is no more checked.
>
> Signed-off-by: Nikita Kiryushin <kiryushin@ancud.ru>
> Reviewed-by: Michael Chan <michael.chan@broadcom.com>
> ---
> Resubmitted tha patch as it was applied to wrong tree and then
> reverted in commit 72076fc9fe60

I am not sure I understand this patch, commit d72b735712e65, which is
the same patch, is already applied, right?

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]