* Re: [PATCH v2] riscv: use KERN_INFO in do_trap
2024-03-19 15:40 [PATCH v2] riscv: use KERN_INFO in do_trap Andreas Schwab
@ 2024-03-19 19:46 ` Atish Patra
2024-03-20 2:20 ` [External] " yunhui cui
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Atish Patra @ 2024-03-19 19:46 UTC (permalink / raw)
To: Andreas Schwab, linux-riscv
Cc: Conor Dooley, Palmer Dabbelt, Yunhui Cui, Björn Töpel,
linux-kernel
On 3/19/24 08:40, Andreas Schwab wrote:
> Print the instruction dump with info instead of emergency level. The
> unhandled signal message is only for informational purpose.
>
> Fixes: b8a03a634129 ("riscv: add userland instruction dump to RISC-V splats")
> Signed-off-by: Andreas Schwab <schwab@suse.de>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> v2: clarify commit message
> ---
> arch/riscv/kernel/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
> index a1b9be3c4332..142f5f5168fb 100644
> --- a/arch/riscv/kernel/traps.c
> +++ b/arch/riscv/kernel/traps.c
> @@ -121,7 +121,7 @@ void do_trap(struct pt_regs *regs, int signo, int code, unsigned long addr)
> print_vma_addr(KERN_CONT " in ", instruction_pointer(regs));
> pr_cont("\n");
> __show_regs(regs);
> - dump_instr(KERN_EMERG, regs);
> + dump_instr(KERN_INFO, regs);
> }
>
> force_sig_fault(signo, code, (void __user *)addr);
Reviewed-by: Atish Patra <atishp@rivosinc.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [External] [PATCH v2] riscv: use KERN_INFO in do_trap
2024-03-19 15:40 [PATCH v2] riscv: use KERN_INFO in do_trap Andreas Schwab
2024-03-19 19:46 ` Atish Patra
@ 2024-03-20 2:20 ` yunhui cui
2024-04-04 13:41 ` Andreas Schwab
2024-04-04 19:40 ` patchwork-bot+linux-riscv
3 siblings, 0 replies; 6+ messages in thread
From: yunhui cui @ 2024-03-20 2:20 UTC (permalink / raw)
To: Andreas Schwab
Cc: linux-riscv, Conor Dooley, Palmer Dabbelt, Björn Töpel,
linux-kernel
Hi Andreas,
On Tue, Mar 19, 2024 at 11:40 PM Andreas Schwab <schwab@suse.de> wrote:
>
> Print the instruction dump with info instead of emergency level. The
> unhandled signal message is only for informational purpose.
>
> Fixes: b8a03a634129 ("riscv: add userland instruction dump to RISC-V splats")
> Signed-off-by: Andreas Schwab <schwab@suse.de>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> v2: clarify commit message
> ---
> arch/riscv/kernel/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
> index a1b9be3c4332..142f5f5168fb 100644
> --- a/arch/riscv/kernel/traps.c
> +++ b/arch/riscv/kernel/traps.c
> @@ -121,7 +121,7 @@ void do_trap(struct pt_regs *regs, int signo, int code, unsigned long addr)
> print_vma_addr(KERN_CONT " in ", instruction_pointer(regs));
> pr_cont("\n");
> __show_regs(regs);
> - dump_instr(KERN_EMERG, regs);
> + dump_instr(KERN_INFO, regs);
> }
>
> force_sig_fault(signo, code, (void __user *)addr);
> --
> 2.44.0
>
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."
Reviewed-by: Yunhui Cui <cuiyunhui@bytedance.com>
Thanks,
Yunhui
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] riscv: use KERN_INFO in do_trap
2024-03-19 15:40 [PATCH v2] riscv: use KERN_INFO in do_trap Andreas Schwab
2024-03-19 19:46 ` Atish Patra
2024-03-20 2:20 ` [External] " yunhui cui
@ 2024-04-04 13:41 ` Andreas Schwab
2024-04-04 14:45 ` Palmer Dabbelt
2024-04-04 19:40 ` patchwork-bot+linux-riscv
3 siblings, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2024-04-04 13:41 UTC (permalink / raw)
To: linux-riscv
Cc: Conor Dooley, Palmer Dabbelt, Yunhui Cui, Björn Töpel,
linux-kernel
Ping!
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] riscv: use KERN_INFO in do_trap
2024-03-19 15:40 [PATCH v2] riscv: use KERN_INFO in do_trap Andreas Schwab
` (2 preceding siblings ...)
2024-04-04 13:41 ` Andreas Schwab
@ 2024-04-04 19:40 ` patchwork-bot+linux-riscv
3 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+linux-riscv @ 2024-04-04 19:40 UTC (permalink / raw)
To: Andreas Schwab; +Cc: linux-riscv, conor, palmer, cuiyunhui, bjorn, linux-kernel
Hello:
This patch was applied to riscv/linux.git (fixes)
by Palmer Dabbelt <palmer@rivosinc.com>:
On Tue, 19 Mar 2024 16:40:05 +0100 you wrote:
> Print the instruction dump with info instead of emergency level. The
> unhandled signal message is only for informational purpose.
>
> Fixes: b8a03a634129 ("riscv: add userland instruction dump to RISC-V splats")
> Signed-off-by: Andreas Schwab <schwab@suse.de>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> [...]
Here is the summary with links:
- [v2] riscv: use KERN_INFO in do_trap
https://git.kernel.org/riscv/c/dd33e5dc7247
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread