Re: [PATCH rdma-next v4 0/4] Define and use mana queues for CQs and WQs

Leon Romanovsky
2024-04-08T11:25:37Z

On Mon, Apr 08, 2024 at 02:14:02AM -0700, Konstantin Taranov wrote:
> From: Konstantin Taranov <kotaranov@microsoft.com>
>
> This patch series aims to reduce code duplication by
> introducing a notion of mana ib queues and corresponding helpers
> to create and destroy them.
>
> v3->v4:
> * Removed debug prints in patches, as asked by Leon
>
> v2->v3:
> * [in 4/4] Do not define an additional struct for a raw qp
>
> v1->v2:
> * [in 1/4] Added a comment about the ignored return value
> * [in 2/4] Replaced RDMA:mana_ib to RDMA/mana_ib in the subject
> * [in 4/4] Renamed mana_ib_raw_qp to mana_ib_raw_sq
>
> Konstantin Taranov (4):
> RDMA/mana_ib: Introduce helpers to create and destroy mana queues
> RDMA/mana_ib: Use struct mana_ib_queue for CQs
> RDMA/mana_ib: Use struct mana_ib_queue for WQs
> RDMA/mana_ib: Use struct mana_ib_queue for RAW QPs
>
> drivers/infiniband/hw/mana/cq.c | 52 +++-------------
> drivers/infiniband/hw/mana/main.c | 39 ++++++++++++
> drivers/infiniband/hw/mana/mana_ib.h | 26 ++++----
> drivers/infiniband/hw/mana/qp.c | 93 +++++++++-------------------
> drivers/infiniband/hw/mana/wq.c | 33 ++--------
> 5 files changed, 96 insertions(+), 147 deletions(-)

It doesn't apply.

Grabbing thread from lore.kernel.org/all/1712567646-5247-1-git-send-email-kotaranov@linux.microsoft.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 5 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Checking attestation on all messages, may take a moment...
Retrieving CI status, may take a moment...
---
✓ [PATCH v4 1/4] RDMA/mana_ib: Introduce helpers to create and destroy mana queues
+ Link: https://lore.kernel.org/r/1712567646-5247-2-git-send-email-kotaranov@linux.microsoft.com
+ Signed-off-by: Leon Romanovsky <leon@kernel.org>
✓ [PATCH v4 2/4] RDMA/mana_ib: Use struct mana_ib_queue for CQs
+ Link: https://lore.kernel.org/r/1712567646-5247-3-git-send-email-kotaranov@linux.microsoft.com
+ Signed-off-by: Leon Romanovsky <leon@kernel.org>
✓ [PATCH v4 3/4] RDMA/mana_ib: Use struct mana_ib_queue for WQs
+ Link: https://lore.kernel.org/r/1712567646-5247-4-git-send-email-kotaranov@linux.microsoft.com
+ Signed-off-by: Leon Romanovsky <leon@kernel.org>
✓ [PATCH v4 4/4] RDMA/mana_ib: Use struct mana_ib_queue for RAW QPs
+ Link: https://lore.kernel.org/r/1712567646-5247-5-git-send-email-kotaranov@linux.microsoft.com
+ Signed-off-by: Leon Romanovsky <leon@kernel.org>
---
✓ Signed: DKIM/linux.microsoft.com
---
Total patches: 4
---
Base: using specified base-commit 96d9cbe2f2ff7abde021bac75eafaceabe9a51fa
Applying: RDMA/mana_ib: Introduce helpers to create and destroy mana queues
Patch failed at 0001 RDMA/mana_ib: Introduce helpers to create and destroy mana queues
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
error: patch failed: drivers/infiniband/hw/mana/main.c:237
error: drivers/infiniband/hw/mana/main.c: patch does not apply
error: patch failed: drivers/infiniband/hw/mana/mana_ib.h:45
error: drivers/infiniband/hw/mana/mana_ib.h: patch does not apply
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Press any key to continue...