Re: [PATCH 2/2] ipv4/route: avoid unused-but-set-variable warning

Eric Dumazet
2024-04-08T08:47:30Z

On Mon, Apr 8, 2024 at 9:42 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The log_martians variable is only used in an #ifdef, causing a 'make W=1'
> warning with gcc:
>
> net/ipv4/route.c: In function 'ip_rt_send_redirect':
> net/ipv4/route.c:880:13: error: variable 'log_martians' set but not used [-Werror=unused-but-set-variable]
>
> Change the #ifdef to an equivalent IS_ENABLED() to let the compiler
> see where the variable is used.
>
> Fixes: 30038fc61adf ("net: ip_rt_send_redirect() optimization")
> Reviewed-by: David Ahern <dsahern@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

A Fixes: tag like this seems overkill, I doubt W=1 was the norm for
old kernels...

Reviewed-by: Eric Dumazet <edumazet@google.com>

Thanks.