From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932274AbdHWP4c (ORCPT ); Wed, 23 Aug 2017 11:56:32 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:63547 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932109AbdHWP4a (ORCPT ); Wed, 23 Aug 2017 11:56:30 -0400 X-AuditID: b6c32a48-f79a16d00000362a-88-599da5abaf2d From: Bartlomiej Zolnierkiewicz To: David Lechner Cc: Geert Uytterhoeven , Linux Fbdev development list , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] fbcon: add fbcon=margin: command line option Date: Wed, 23 Aug 2017 17:56:25 +0200 Message-id: <1712803.5baJPN1EnC@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <0f404f59-f494-bd33-9a9a-f9b07a0dd7ee@lechnology.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsWy7bCmme7qpXMjDU49sbZY1CBm8ezWXiaL E30fWC0u75rD5sDi8an/JKvHocMdjB6fN8kFMEdx2aSk5mSWpRbp2yVwZfStbGApmChQsXjS GaYGxs08XYycHBICJhJ3Wx+zQNhiEhfurWcDsYUEdjBK/D2j3MXIBWR/Z5SYe6qfHabhwrdm NojEBkaJo+8+sUA4Xxkljjc/ZQKpYhOwkpjYvoqxi5GDQ0RAQ+JFpxtIDbPAGkaJaz/3MYLU CAt4S5xcdQ9sNYuAqsTn+e9ZQWxeAU2JzRNfgMVFBbwktuxrZwKZwyngJLGslwWiRFDix2SI VmYBeYl9+6eyQtg6EmePrWME2SUhMINN4vCNW6wgvRICLhJPjitAPCAs8er4FqhnpCWerdrI CGFPZ5TY/lsConczo8Sq3ROgiqwlDh+/CLWAT6Lj8F92iJm8Eh1tQhAlHhKdW7YwQ4QdJc5M V4UEyQVGiaUv5zBPYJSbheTsWUjOnoXk7AWMzKsYxVILinPTU4uNCkz0ihNzi0vz0vWS83M3 MYKTgJbHDsYD53wOMQpwMCrx8GosmRspxJpYVlyZe4hRgoNZSYR3PkiINyWxsiq1KD++qDQn tfgQozQHi5I4b922axFCAumJJanZqakFqUUwWSYOTqkGxjVXUhZ7bNkjv8ro4cuTU3fFXZvm 7pem8efL5Rl7bOadMfKq2bH22W4n04BtEafkTYM9NRwntuvdeFQ7PWPv+VZtE1/5bXaiuzRj fy+2imSu0l2WyvlBwth/zp3lazZVfJidGrh2c8T20qxvBczfzgpUNx/b9/jT5JQlOt6/JAM4 4wM8Ktn3HlZiKc5INNRiLipOBAByOdap/gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBLMWRmVeSWpSXmKPExsVy+t9jQd3VS+dGGrRNl7dY1CBm8ezWXiaL E30fWC0u75rD5sDi8an/JKvHocMdjB6fN8kFMEdx2aSk5mSWpRbp2yVwZfStbGApmChQsXjS GaYGxs08XYycHBICJhIXvjWzdTFycQgJrGOU+DVrJzOE85VRovHtRnaQKjYBK4mJ7asYuxg5 OEQENCRedLqBhJkF1jBKzLgQDWILC3hLnFx1jwXEZhFQlfg8/z0riM0roCmxeeILsLiogJfE ln3tTCBjOAWcJJb1goWFBC4wSmxoroIoF5T4MRliDLOAvMS+/VNZIWwtifU7jzNNYOSfhaRs FpKyWUjKFjAyr2KUTC0ozk3PLTYqMMpLLdcrTswtLs1L10vOz93ECAzPbYe1+ncwPl4Sf4hR gINRiYf3wsK5kUKsiWXFlbmHGCU4mJVEeOcvAQrxpiRWVqUW5ccXleakFh9ilOZgURLnzeyb ESkkkJ5YkpqdmlqQWgSTZeLglGpgDEqZ5vL/j5VAw+TtLz8Y+qe55map/9j5SeqRe8ettlfJ MjcLboUIfVvCpr616EeLzeeje39zGy5gOmVXI/jr5J7+sNqOXx8t/oTYVeW8y7YWLbv/erLi tYAOz86CkBDNi3fe+67kYtPNOFlcVPJ6QY45s9xZOVnPXTxLJA+4hO6q3eDA2zRZiaU4I9FQ i7moOBEA+T+JD0sCAAA= X-CMS-MailID: 20170823155627epcas2p2660cb305980f6bde75774f6521ea205c X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 102P X-CMS-RootMailID: 20170818191930epcas3p16e6cac84fc9579a57208110214773221 X-RootMTR: 20170818191930epcas3p16e6cac84fc9579a57208110214773221 References: <1501605357-30815-1-git-send-email-david@lechnology.com> <0f404f59-f494-bd33-9a9a-f9b07a0dd7ee@lechnology.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Friday, August 18, 2017 02:19:28 PM David Lechner wrote: > On 08/18/2017 01:21 PM, Geert Uytterhoeven wrote: > > Hi David, > > > > On Tue, Aug 1, 2017 at 6:35 PM, David Lechner wrote: > >> This adds a new command line option to select the fbcon margin color. > >> > >> The motivation for this is screens where black does not blend into the > >> physical surroundings of the screen. For example, using an LCD (not the > >> backlit kind), white text on a black background is hard to read, so > >> inverting the colors is preferred. However, when you do this, most of the > >> screen is filled with white but the margins are still filled with black. > >> This makes a big, black, backwards 'L' on the screen. By setting > >> fbcon=margin:7, the margins will be filled with white and the LCD looks as > >> expected. > >> > >> Signed-off-by: David Lechner > > > >> --- a/Documentation/fb/fbcon.txt > >> +++ b/Documentation/fb/fbcon.txt > >> @@ -148,6 +148,13 @@ C. Boot options > >> Actually, the underlying fb driver is totally ignorant of console > >> rotation. > >> > >> +5. fbcon=margin: > >> + > >> + This option specifies the color of the margins. The margins are the > >> + leftover area at the right and the bottom of the screen that are not > >> + used by text. By default, this area will be black. The 'color' value > >> + is 0 to 7 where 0 is black and 7 is white. > >> + > > > > Given the standard console palette contains 16 colors, why limit this to > > the first 8 colors, and not 0 to 15? > > Good question. I think in some of my previous attempts there was a 0x7 > mask involved somewhere and this is a carryover from that. But, after > having looked at this again, I don't see a reason for limiting to 7. Could you please prepare the incremental patch raising the number of colors possible to use? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics