* [PATCH v2] net: usb: ax88179_178a: Add check for usbnet_get_endpoints()
@ 2024-04-24 6:56 Ma Ke
2024-04-24 8:49 ` Hariprasad Kelam
2024-04-26 2:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Ma Ke @ 2024-04-24 6:56 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, jtornosm, andrew, horms,
hkallweit1, make_ruc2021
Cc: linux-usb, netdev, linux-kernel
To avoid the failure of usbnet_get_endpoints(), we should check the
return value of the usbnet_get_endpoints().
Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
drivers/net/usb/ax88179_178a.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index 752f821a1990..388ea178c91d 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -1287,8 +1287,11 @@ static void ax88179_get_mac_addr(struct usbnet *dev)
static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf)
{
struct ax88179_data *ax179_data;
+ int ret;
- usbnet_get_endpoints(dev, intf);
+ ret = usbnet_get_endpoints(dev, intf);
+ if (ret < 0)
+ return ret;
ax179_data = kzalloc(sizeof(*ax179_data), GFP_KERNEL);
if (!ax179_data)
--
2.37.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2] net: usb: ax88179_178a: Add check for usbnet_get_endpoints()
2024-04-24 6:56 [PATCH v2] net: usb: ax88179_178a: Add check for usbnet_get_endpoints() Ma Ke
@ 2024-04-24 8:49 ` Hariprasad Kelam
2024-04-24 12:24 ` Andrew Lunn
2024-04-26 2:00 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Hariprasad Kelam @ 2024-04-24 8:49 UTC (permalink / raw)
To: Ma Ke, davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, jtornosm@redhat.com, andrew@lunn.ch,
horms@kernel.org, hkallweit1@gmail.com
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
> To avoid the failure of usbnet_get_endpoints(), we should check the return
> value of the usbnet_get_endpoints().
>
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> ---
> drivers/net/usb/ax88179_178a.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/ax88179_178a.c
> b/drivers/net/usb/ax88179_178a.c index 752f821a1990..388ea178c91d
> 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
> @@ -1287,8 +1287,11 @@ static void ax88179_get_mac_addr(struct usbnet
> *dev) static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf) {
> struct ax88179_data *ax179_data;
> + int ret;
>
> - usbnet_get_endpoints(dev, intf);
> + ret = usbnet_get_endpoints(dev, intf);
> + if (ret < 0)
> + return ret;
>
> ax179_data = kzalloc(sizeof(*ax179_data), GFP_KERNEL);
> if (!ax179_data)
> --
> 2.37.2
>
Nit: please include patch change log, below link required info
https://docs.kernel.org/process/submitting-patches.html
Reviewed-by: Hariprasad Kelam <hkelam@marvell.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] net: usb: ax88179_178a: Add check for usbnet_get_endpoints()
2024-04-24 8:49 ` Hariprasad Kelam
@ 2024-04-24 12:24 ` Andrew Lunn
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2024-04-24 12:24 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: Ma Ke, davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, jtornosm@redhat.com, horms@kernel.org,
hkallweit1@gmail.com, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
> Nit: please include patch change log, below link required info
> https://docs.kernel.org/process/submitting-patches.html
Also, please wait at least 24 hours before submitting new versions,
even when the previous version is completely broken and does not
compile:
https://patchwork.kernel.org/project/netdevbpf/patch/20240424011454.1554088-1-make_ruc2021@163.com/
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] net: usb: ax88179_178a: Add check for usbnet_get_endpoints()
2024-04-24 6:56 [PATCH v2] net: usb: ax88179_178a: Add check for usbnet_get_endpoints() Ma Ke
2024-04-24 8:49 ` Hariprasad Kelam
@ 2024-04-26 2:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-04-26 2:00 UTC (permalink / raw)
To: Ma Ke
Cc: davem, edumazet, kuba, pabeni, jtornosm, andrew, horms,
hkallweit1, linux-usb, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 24 Apr 2024 14:56:34 +0800 you wrote:
> To avoid the failure of usbnet_get_endpoints(), we should check the
> return value of the usbnet_get_endpoints().
>
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> ---
> drivers/net/usb/ax88179_178a.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Here is the summary with links:
- [v2] net: usb: ax88179_178a: Add check for usbnet_get_endpoints()
https://git.kernel.org/netdev/net-next/c/3837639ebfdd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-26 2:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-24 6:56 [PATCH v2] net: usb: ax88179_178a: Add check for usbnet_get_endpoints() Ma Ke
2024-04-24 8:49 ` Hariprasad Kelam
2024-04-24 12:24 ` Andrew Lunn
2024-04-26 2:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox