From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757286AbcAJSYD (ORCPT <rfc822;w@1wt.eu>);
	Sun, 10 Jan 2016 13:24:03 -0500
Received: from gloria.sntech.de ([95.129.55.99]:54299 "EHLO gloria.sntech.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756583AbcAJSYA convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 10 Jan 2016 13:24:00 -0500
From: Heiko Stuebner <heiko@sntech.de>
To: Xing Zheng <zhengxing@rock-chips.com>
Cc: linux-rockchip@lists.infradead.org, keescook@google.com,
        leozwang@google.com, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        xing.zheng@rock-chips.com
Subject: Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
Date: Sun, 10 Jan 2016 19:23:40 +0100
Message-ID: <1714176.Nme8cQ9zc4@phil>
User-Agent: KMail/4.14.10 (Linux/4.3.0-trunk-amd64; KDE/4.14.14; x86_64; ; )
In-Reply-To: <B588B7A8-EC8A-44A5-AEDF-F75AB5361F01@rock-chips.com>
References: <1452410557-29208-1-git-send-email-zhengxing@rock-chips.com> <E6BB80D3-5A62-4BE1-BFC2-74DAC9213C95@rock-chips.com> <B588B7A8-EC8A-44A5-AEDF-F75AB5361F01@rock-chips.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="utf-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Sonntag, 10. Januar 2016, 18:36:12 schrieb Xing Zheng:
> Hi Heiko,
> 
> > 在 2016年1月10日，18:29，Xing Zheng <zhengxing@rock-chips.com> 写道：
> > 
> > 
> > Hi Heiko,
> > 
> >> 在 2016年1月10日，17:59，Heiko Stuebner <heiko@sntech.de> 写道：
> >> 
> >> Hi Xing,
> >> 
> >> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
> >>> Because the RK3036 doesn't support EMAC, and only support the RMII
> >>> mode
> >>> in the EMAC IP, we refer to the TRM CRU and update the new external
> >>> clock name for EMAC.
> >>> 
> >>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> >> 
> >> as I said in the other mail, I already fixed the original patch myself
> >> :-) So I'm just going to drop this one.
> >> 
> >> 
> >> Heiko
> >> 
> >> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/c
> >> ommit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931> 
> > I am sorry to misunderstand.
> > 
> > OK, thank you for your help.  :)
> 
> Your patch is:
> - - "ext_gmac" - external GMAC clock - optional
> + - "rmii_clkin" - external GMAC clock - optional
> 
> I think that these should be like this:
> - - "ext_gmac" - external GMAC clock - optional
> + - "rmii_clkin" - external EMAC clock - optional

I fixed that up now, thanks for catching this.

https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=1c888eb1054a08620a8d2bc5dd2d7cc290897371


Heiko