From: Tom Zanussi <zanussi@us.ibm.com>
To: Hareesh Nagarajan <hareesh@google.com>
Cc: Andrew Morton <akpm@osdl.org>, Tom Zanussi <zanussi@us.ibm.com>,
linux-kernel@vger.kernel.org, karim@opersys.com
Subject: Re: [PATCH] [TRIVIAL] relayfs: remove comment on overwrite mode
Date: Mon, 15 Aug 2005 09:58:40 -0500 [thread overview]
Message-ID: <17152.44448.916315.2363@tut.ibm.com> (raw)
In-Reply-To: <43001B44.3050205@google.com>
Hareesh Nagarajan writes:
> Hi Andrew,
>
> The overwrite arg has been removed from the relay_subbufs_consumed()
> (since it has been removed from relayfs altogether) so the comment
> preceding the function must go.
relayfs still supports overwrite mode, but it's now implemented
differently (via the subbuf_start() callback instead of an overwrite
arg), so this comment is still valid.
Tom
>
> Thanks,
>
> Hareesh
> diff -ruN linux-akpm/fs/relayfs/relay.c linux/fs/relayfs/relay.c
> --- linux-akpm/fs/relayfs/relay.c 2005-08-14 21:16:35.000000000 -0700
> +++ linux/fs/relayfs/relay.c 2005-08-14 21:26:10.000000000 -0700
> @@ -342,9 +342,6 @@
> * Adds to the channel buffer's consumed sub-buffer count.
> * subbufs_consumed should be the number of sub-buffers newly consumed,
> * not the total consumed.
> - *
> - * NOTE: kernel clients don't need to call this function if the channel
> - * mode is 'overwrite'.
> */
> void relay_subbufs_consumed(struct rchan *chan,
> unsigned int cpu,
prev parent reply other threads:[~2005-08-15 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-15 4:34 [PATCH] [TRIVIAL] relayfs: remove comment on overwrite mode Hareesh Nagarajan
2005-08-15 14:58 ` Tom Zanussi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17152.44448.916315.2363@tut.ibm.com \
--to=zanussi@us.ibm.com \
--cc=akpm@osdl.org \
--cc=hareesh@google.com \
--cc=karim@opersys.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox