From: patchwork-bot+netdevbpf@kernel.org
To: Breno Leitao <leitao@debian.org>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, thepacketgeek@gmail.com, aijay@meta.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] netconsole: Do not shutdown dynamic configuration if cmdline is invalid
Date: Thu, 30 May 2024 00:30:32 +0000 [thread overview]
Message-ID: <171702903299.18765.2718725823072532974.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240528084225.3215853-1-leitao@debian.org>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 28 May 2024 01:42:24 -0700 you wrote:
> If a user provides an invalid netconsole configuration during boot time
> (e.g., specifying an invalid ethX interface), netconsole will be
> entirely disabled. Consequently, the user won't be able to create new
> entries in /sys/kernel/config/netconsole/ as that directory does not
> exist.
>
> Apart from misconfiguration, another issue arises when ethX is loaded as
> a module and the netconsole= line in the command line points to ethX,
> resulting in an obvious failure. This renders netconsole unusable, as
> /sys/kernel/config/netconsole/ will never appear. This is more annoying
> since users reconfigure (or just toggle) the configuratin later (see
> commit 5fbd6cdbe304b ("netconsole: Attach cmdline target to dynamic
> target"))
>
> [...]
Here is the summary with links:
- [net,v2] netconsole: Do not shutdown dynamic configuration if cmdline is invalid
https://git.kernel.org/netdev/net-next/c/c3390677f625
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-05-30 0:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 8:42 [PATCH net v2] netconsole: Do not shutdown dynamic configuration if cmdline is invalid Breno Leitao
2024-05-30 0:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171702903299.18765.2718725823072532974.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=aijay@meta.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thepacketgeek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox