RE: [PATCH net-next v2] net: xilinx: axienet: Use NL_SET_ERR_MSG instead of netdev_err

Pandey, Radhey Shyam
2024-06-11T19:05:34Z

> -----Original Message-----
> From: Sean Anderson <sean.anderson@linux.dev>
> Sent: Tuesday, June 11, 2024 9:11 PM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>; Andrew
> Lunn <andrew@lunn.ch>; netdev@vger.kernel.org
> Cc: Jakub Kicinski <kuba@kernel.org>; linux-kernel@vger.kernel.org; Russell
> King <linux@armlinux.org.uk>; Simek, Michal <michal.simek@amd.com>;
> Paolo Abeni <pabeni@redhat.com>; Eric Dumazet <edumazet@google.com>;
> David S . Miller <davem@davemloft.net>; linux-arm-
> kernel@lists.infradead.org; Sean Anderson <sean.anderson@linux.dev>
> Subject: [PATCH net-next v2] net: xilinx: axienet: Use NL_SET_ERR_MSG
> instead of netdev_err
>
> This error message can be triggered by userspace. Use NL_SET_ERR_MSG so
> the message is returned to the user and to avoid polluting the kernel
> logs. Additionally, change the return value from EFAULT to EBUSY to
> better reflect the error (which has nothing to do with addressing).
>
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Thanks!
> ---
>
> Changes in v2:
> - Split off from stats series
> - Document return value change
>
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index c29809cd9201..5f98daa5b341 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -1945,9 +1945,9 @@ axienet_ethtools_set_coalesce(struct net_device
> *ndev,
> struct axienet_local *lp = netdev_priv(ndev);
>
> if (netif_running(ndev)) {
> - netdev_err(ndev,
> - "Please stop netif before applying
> configuration\n");
> - return -EFAULT;
> + NL_SET_ERR_MSG(extack,
> + "Please stop netif before applying
> configuration");
> + return -EBUSY;
> }
>
> if (ecoalesce->rx_max_coalesced_frames)
> --
> 2.35.1.1320.gc452695387.dirty