The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Chen-Yu Tsai <wens@kernel.org>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
	 Jernej Skrabec <jernej.skrabec@gmail.com>,
	 Samuel Holland <samuel@sholland.org>,
	Albert Ou <aou@eecs.berkeley.edu>,  Chen-Yu Tsai <wens@csie.org>,
	linux-sunxi@lists.linux.dev,
	 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	 linux-riscv@lists.infradead.org,
	Palmer Dabbelt <palmer@dabbelt.com>,
	 devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: sram: sunxi-sram: Add regulators child
Date: Sat, 22 Jun 2024 10:35:58 -0600	[thread overview]
Message-ID: <171907415897.1042829.2907756455868106157.robh@kernel.org> (raw)
In-Reply-To: <20240622150731.1105901-2-wens@kernel.org>


On Sat, 22 Jun 2024 23:07:29 +0800, Chen-Yu Tsai wrote:
> From: Samuel Holland <samuel@sholland.org>
> 
> Some sunxi SoCs have in-package regulators controlled by a register in
> the system control MMIO block. Allow a child node for this regulator
> device in addition to SRAM child nodes.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>  .../allwinner,sun4i-a10-system-control.yaml   | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.example.dtb: syscon@3000000: regulators@3000150: False schema does not allow {'compatible': ['allwinner,sun20i-d1-system-ldos'], 'reg': [[50331984, 4]], 'ldoa': {'regulator-min-microvolt': [[1800000]], 'regulator-max-microvolt': [[1800000]]}, 'ldob': {'regulator-name': ['vcc-dram'], 'regulator-min-microvolt': [[1500000]], 'regulator-max-microvolt': [[1500000]]}}
	from schema $id: http://devicetree.org/schemas/sram/allwinner,sun4i-a10-system-control.yaml#
Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.example.dtb: /example-1/syscon@3000000/regulators@3000150: failed to match any schema with compatible: ['allwinner,sun20i-d1-system-ldos']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240622150731.1105901-2-wens@kernel.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-06-22 16:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-22 15:07 [PATCH 0/3] riscv: allwinner: ClockworkPi and DevTerm devicetrees Chen-Yu Tsai
2024-06-22 15:07 ` [PATCH 1/3] dt-bindings: sram: sunxi-sram: Add regulators child Chen-Yu Tsai
2024-06-22 16:35   ` Rob Herring (Arm) [this message]
2024-06-22 16:46     ` Chen-Yu Tsai
2024-06-23 14:28       ` Conor Dooley
2024-06-22 15:07 ` [PATCH 2/3] riscv: dts: allwinner: d1s-t113: Add system LDOs Chen-Yu Tsai
2024-06-22 15:07 ` [PATCH 3/3] riscv: dts: allwinner: Add ClockworkPi and DevTerm devicetrees Chen-Yu Tsai
2024-06-30 15:06 ` (subset) [PATCH 0/3] riscv: allwinner: " Chen-Yu Tsai
2024-06-30 15:09 ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171907415897.1042829.2907756455868106157.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox