The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-mediatek@lists.infradead.org,
	Conor Dooley <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Shan-Chun Hung <schung@nuvoton.com>,
	Orson Zhai <orsonzhai@gmail.com>,
	Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	UNGLinuxDriver@microchip.com,
	Steen Hegelund <Steen.Hegelund@microchip.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>,
	Khuong Dinh <khuong@os.amperecomputing.com>,
	linux-arm-kernel@lists.infradead.org,
	Lars Povlsen <lars.povlsen@microchip.com>,
	Jiaxun Yang <jiaxun.yang@flygoat.com>, Lee Jones <lee@kernel.org>,
	Daniel Machon <daniel.machon@microchip.com>,
	Nishanth Menon <nm@ti.com>, Jacky Huang <ychuang3@nuvoton.com>,
	devicetree@vger.kernel.org,
	Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH v2 6/7] dt-bindings: mfd: syscon: Split and enforce documenting MFD children
Date: Mon, 24 Jun 2024 14:28:25 -0600	[thread overview]
Message-ID: <171926090377.354722.8861218849398833034.robh@kernel.org> (raw)
In-Reply-To: <20240616-dt-bindings-mfd-syscon-split-v2-6-571b5850174a@linaro.org>


On Sun, 16 Jun 2024 15:19:26 +0200, Krzysztof Kozlowski wrote:
> Simple syscon nodes can be documented in common syscon.yaml, however
> devices with simple-mfd compatible, thus with some children, should have
> their own schema listing these children.  Such listing makes the binding
> specific, allows better validation (so the incorrect child would not
> appear in the simple-mfd node) and actually enforces repeated rule for
> simple-mfd devices:
> 
>   "simple-mfd" is only for simple devices, where the children do not
>   depend on the parent.
> 
> Currently the syscon+simple-mfd binding is quite broad and allows
> any child or property, thus above rule cannot be enforced.
> 
> Split the syscon.yaml binding into:
> 1. Common syscon properties, used potentially by many bindings.
> 2. Simple syscon devices (NO simple-mfd!).
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Depends on:
> 1. Patch in MFD: https://lore.kernel.org/all/171828959006.2643902.8308227314531523435.b4-ty@kernel.org/
> 2. Previous patches in the series.
> ---
>  .../devicetree/bindings/mfd/syscon-common.yaml     |  72 +++++
>  Documentation/devicetree/bindings/mfd/syscon.yaml  | 294 +++++++++++++--------
>  2 files changed, 251 insertions(+), 115 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


  parent reply	other threads:[~2024-06-24 20:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-16 13:19 [PATCH v2 0/7] dt-bindings: mfd: syscon: Document more compatibles and require simpe-mfd description Krzysztof Kozlowski
2024-06-16 13:19 ` [PATCH v2 1/7] dt-bindings: mfd: syscon: Drop hwlocks Krzysztof Kozlowski
2024-06-16 13:19 ` [PATCH v2 2/7] dt-bindings: soc: sprd: sc9863a-glbregs: Document SC9863A syscon Krzysztof Kozlowski
2024-06-18  8:52   ` Baolin Wang
2024-06-16 13:19 ` [PATCH v2 3/7] dt-bindings: soc: intel: lgm-syscon: Move to dedicated schema Krzysztof Kozlowski
2024-06-17 16:46   ` Conor Dooley
2024-06-17 16:47   ` Conor Dooley
2024-06-17 17:39     ` Krzysztof Kozlowski
2024-06-24 20:34   ` Rob Herring (Arm)
2024-06-16 13:19 ` [PATCH v2 4/7] dt-bindings: soc: microchip: sparx5-cpu-syscon: " Krzysztof Kozlowski
2024-06-16 13:19 ` [PATCH v2 5/7] dt-bindings: soc: ti: am654-serdes-ctrl: " Krzysztof Kozlowski
2024-06-16 13:19 ` [PATCH v2 6/7] dt-bindings: mfd: syscon: Split and enforce documenting MFD children Krzysztof Kozlowski
2024-06-17 16:44   ` Conor Dooley
2024-06-17 16:46     ` Conor Dooley
2024-06-17 17:35       ` Krzysztof Kozlowski
2024-06-18 18:04         ` Conor Dooley
2024-06-17 17:33     ` Krzysztof Kozlowski
2024-06-24 20:28   ` Rob Herring (Arm) [this message]
2024-06-16 13:19 ` [PATCH v2 7/7] dt-bindings: mfd: syscon: Add APM poweroff mailbox Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171926090377.354722.8861218849398833034.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Steen.Hegelund@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.machon@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=khuong@os.amperecomputing.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lars.povlsen@microchip.com \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nm@ti.com \
    --cc=orsonzhai@gmail.com \
    --cc=schung@nuvoton.com \
    --cc=vadivel.muruganx.ramuthevar@linux.intel.com \
    --cc=ychuang3@nuvoton.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox