[PATCH net-next] net: dpaa: Fix compilation Warning

[PATCH net-next] net: dpaa: Fix compilation Warning

[Breno Leitao]

Remove variables that are defined and incremented but never read.
This issue appeared in network tests[1] as:

	drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c:38:6: warning: variable 'i' set but not used [-Wunused-but-set-variable]
	38 |         int i = 0;
	   |             ^

Link: https://netdev.bots.linux.dev/static/nipa/870263/13729811/build_clang/stderr [1]
Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c
index 4fee74c024bd..aad470e9caea 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c
@@ -35,7 +35,6 @@ static ssize_t dpaa_eth_show_fqids(struct device *dev,
 	u32 last_fqid = 0;
 	ssize_t bytes = 0;
 	char *str;
-	int i = 0;
 
 	list_for_each_entry_safe(fq, tmp, &priv->dpaa_fq_list, list) {
 		switch (fq->fq_type) {
@@ -85,7 +84,6 @@ static ssize_t dpaa_eth_show_fqids(struct device *dev,
 
 		prev = fq;
 		prevstr = str;
-		i++;
 	}
 
 	if (prev) {
-- 
2.43.0

Re: [PATCH net-next] net: dpaa: Fix compilation Warning

[Vladimir Oltean]

On Fri, Jul 12, 2024 at 06:48:16AM -0700, Breno Leitao wrote:
> Remove variables that are defined and incremented but never read.
> This issue appeared in network tests[1] as:
> 
> 	drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c:38:6: warning: variable 'i' set but not used [-Wunused-but-set-variable]
> 	38 |         int i = 0;
> 	   |             ^
> 
> Link: https://netdev.bots.linux.dev/static/nipa/870263/13729811/build_clang/stderr [1]
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Re: [PATCH net-next] net: dpaa: Fix compilation Warning

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 12 Jul 2024 06:48:16 -0700 you wrote:
> Remove variables that are defined and incremented but never read.
> This issue appeared in network tests[1] as:
> 
> 	drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c:38:6: warning: variable 'i' set but not used [-Wunused-but-set-variable]
> 	38 |         int i = 0;
> 	   |             ^
> 
> [...]

Here is the summary with links:
  - [net-next] net: dpaa: Fix compilation Warning
    https://git.kernel.org/netdev/net-next/c/e7cdef626f1d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html