public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Johan Hovold <johan@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Marijn Suijten <marijn.suijten@somainline.org>,
	 linux-arm-msm@vger.kernel.org, Abel Vesa <abel.vesa@linaro.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] ThinkPad T14s Gen 6 support
Date: Mon, 22 Jul 2024 20:57:32 -0600	[thread overview]
Message-ID: <172170324437.205162.5877409275020405960.robh@kernel.org> (raw)
In-Reply-To: <20240719-topic-t14s_upstream-v1-0-d7d97fdebb28@linaro.org>


On Fri, 19 Jul 2024 22:16:35 +0200, Konrad Dybcio wrote:
> As good as the other X1 laptops
> 
> See this page for more hw info:
> 
> https://www.lenovo.com/us/en/p/laptops/thinkpad/thinkpadt/lenovo-thinkpad-t14s-gen-6-(14-inch-snapdragon)/len101t0099
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> Konrad Dybcio (3):
>       dt-bindings: arm: qcom: Add Lenovo ThinkPad T14s Gen 6
>       firmware: qcom: scm: Allow QSEECOM on ThinkPad T14s
>       arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6
> 
>  Documentation/devicetree/bindings/arm/qcom.yaml    |   6 +
>  arch/arm64/boot/dts/qcom/Makefile                  |   1 +
>  .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts     | 792 +++++++++++++++++++++
>  drivers/firmware/qcom/qcom_scm.c                   |   1 +
>  4 files changed, 800 insertions(+)
> ---
> base-commit: 523b23f0bee3014a7a752c9bb9f5c54f0eddae88
> change-id: 20240719-topic-t14s_upstream-e53fcd0ccd2a
> 
> Best regards,
> --
> Konrad Dybcio <konrad.dybcio@linaro.org>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/x1e78100-lenovo-thinkpad-t14s.dtb' for 20240719-topic-t14s_upstream-v1-0-d7d97fdebb28@linaro.org:

arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtb: domain-idle-states: cluster-sleep-0: 'idle-state-name' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/power/domain-idle-state.yaml#
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtb: domain-idle-states: cluster-sleep-1: 'idle-state-name' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/power/domain-idle-state.yaml#
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtb: pci@1bf8000: Unevaluated properties are not allowed ('vddpe-3v3-supply' was unexpected)
	from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-x1e80100.yaml#
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtb: usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#






  parent reply	other threads:[~2024-07-23  2:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-19 20:16 [PATCH 0/3] ThinkPad T14s Gen 6 support Konrad Dybcio
2024-07-19 20:16 ` [PATCH 1/3] dt-bindings: arm: qcom: Add Lenovo ThinkPad T14s Gen 6 Konrad Dybcio
2024-07-21 10:22   ` Krzysztof Kozlowski
2024-07-22 21:24   ` Rob Herring
2024-07-22 22:40     ` Konrad Dybcio
2024-07-19 20:16 ` [PATCH 2/3] firmware: qcom: scm: Allow QSEECOM on ThinkPad T14s Konrad Dybcio
2024-07-21 16:40   ` Abel Vesa
2024-07-19 20:16 ` [PATCH 3/3] arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6 Konrad Dybcio
2024-07-21 16:40   ` Abel Vesa
2024-07-22  8:42     ` Konrad Dybcio
2024-07-22 10:08       ` Abel Vesa
2024-07-22 15:00         ` Rob Clark
2024-07-22 16:03           ` Dmitry Baryshkov
2024-07-23 18:55             ` Bjorn Andersson
2024-07-23 21:28               ` Mark Kettenis
2024-07-29 20:42                 ` Rob Clark
2024-07-22 10:04   ` Johan Hovold
2024-07-23  2:57 ` Rob Herring (Arm) [this message]
2024-07-29  3:58 ` (subset) [PATCH 0/3] ThinkPad T14s Gen 6 support Bjorn Andersson
2024-08-16 16:30   ` Rob Herring
2024-08-26 17:05     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172170324437.205162.5877409275020405960.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=abel.vesa@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox